Remove selinux build tag #931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are using the go module github.com/opencontainers/selinux v1.10.1. This module stopped requiring the "selinux" build tag as of v1.8.0. See https://github.com/opencontainers/selinux/blob/v1.8.0/README.md#usage This reverts commit 0d97d93. Signed-off-by: Daniel Lipovetsky <[email protected]>
k8s-ci-robot
added
kind/cleanup
k8s-ci-robot
added
the
size/XS
|
/cc @AkihiroSuda |
AkihiroSuda
approved these changes
May 11, 2022
saschagrunert
approved these changes
May 12, 2022
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AkihiroSuda, dlipovetsky, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Removes the
selinuxbuild tag.We are using the go module github.com/opencontainers/selinux v1.10.1. This module stopped requiring the
selinuxbuild tag as of v1.8.0. See https://github.com/opencontainers/selinux/blob/v1.8.0/README.md#usage.Which issue(s) this PR fixes:
Special notes for your reviewer:
Just as a point of reference, the runc build used to define the selinux tag, but removed it in opencontainers/runc#2709
Does this PR introduce a user-facing change?