Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cluster provider for K3D #264

Closed
wants to merge 3 commits into from
Closed

Conversation

inercia
Copy link

@inercia inercia commented May 24, 2023

  • Cluster provider for k3d, for building local kubernetes clusters with k3d (faster than kind).
  • Utility function for building images.

Signed-off-by: Alvaro Saurin <[email protected]>
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: inercia
Once this PR has been reviewed and has the lgtm label, please assign vladimirvivien for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from cpanato May 24, 2023 19:50
@k8s-ci-robot k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label May 24, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @inercia!

It looks like this is your first PR to kubernetes-sigs/e2e-framework 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/e2e-framework has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 24, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @inercia. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented May 24, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 24, 2023
inercia added 2 commits May 25, 2023 14:05
Signed-off-by: Alvaro Saurin <[email protected]>
Signed-off-by: Alvaro Saurin <[email protected]>
@jbpratt
Copy link
Contributor

jbpratt commented May 30, 2023

hey @inercia, thanks for the PR! I think we are going to want to work on getting #246 merged in so that we can follow a similar pattern for all the providers (see #239 (comment)). I'll see about helping to move that along (cc @ShwethaKumbla @vladimirvivien)

@inercia
Copy link
Author

inercia commented May 30, 2023

Oh, I see @jbpratt. Then maybe I should wait until #246 is merged and then refactor my PR for following the new interface...

@vladimirvivien
Copy link
Contributor

Thanks for the contribution @inercia .
I second getting #246 over the finish line before we take on this.

Thanks for jumping in @jbpratt

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 18, 2023
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@harshanarayana
Copy link
Contributor

Now that we have gotten #246 merged, @jbpratt @inercia we can work towards taking this forward ?

@harshanarayana
Copy link
Contributor

/ping

@jbpratt @inercia Are you still working on this? If you are not working actively on this, I would be more than happy to push a few changes to this and get this ready for review.

@harshanarayana
Copy link
Contributor

@jbpratt @inercia Just checking to see if you are still working on this ?

@jbpratt
Copy link
Contributor

jbpratt commented Nov 2, 2023

@jbpratt @inercia Just checking to see if you are still working on this ?

I wasn't working on this, just provided a review @harshanarayana

@inercia
Copy link
Author

inercia commented Nov 2, 2023

@jbpratt @harshanarayana I'm not working on this anymore, I will close this PR.

@inercia inercia closed this Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants