Add templates for flux example #283
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
sig/testing
k8s-ci-robot
added
the
needs-ok-to-test
|
Hi @matrus2. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
size/M
| spec: | ||
| containers: | ||
| - name: hello-app | ||
| image: matrus2hub/go-hello-world@sha256:2c4bd6771dbb88db8d8294245d2937f797ff30708d0647aec564e8cd7851c2b5 |
There was a problem hiding this comment.
@cpanato @vladimirvivien do we have an image coming from the kubernetes-sigs that we can use here instead of this ? It would be great if there is one. I did a quick search through the test-infra and did not find one. May be we can just use a simple upstream nginx image instead ? Sorry for being very picky on the source of the images.
There was a problem hiding this comment.
@harshanarayana You are completely right, I switched to nginx instead.
There was a problem hiding this comment.
Along the same line of questioning, @cpanato @harshanarayana, since nginx is on Dockerhub, will repo-testing run into pull throttling issues, causing it to fail ?
There was a problem hiding this comment.
We might very well run into that. But I did a bit of digging around in the test-infra and kubernetes-sigs or and I found a combination of these images used already.
Most of the nginx images used in the k-sigs are from direct dockerhub. But I did find a few other options
registry.k8s.io/nginx-slim:0.8(https://github.com/kubernetes-sigs/gcp-filestore-csi-driver/blob/1712c870e2ed773c3de0be8138502d8bb82c39d0/examples/kubernetes/multishare/maxshares/demo-ss-512.yaml#L21)mcr.microsoft.com/oss/nginx/nginx:1.19.5(https://github.com/kubernetes-sigs/blob-csi-driver/blob/9c74b4a3d14683a26958af9cd2a4f65656f5569e/deploy/example/statefulset.yaml#L20)
I believe it should be ok to use the default dockerhub images so long as we are using the same docker registry credentials in prow for this repo jobs as the one being used for others. cc @cpanato @vladimirvivien
There was a problem hiding this comment.
@vladimirvivien Let us get this one merged. We can revisit the images from a different registry again if we start seeing flaky tests because of the rate limiting.
There was a problem hiding this comment.
Thanks @harshanarayana for looking into this.
/lgtm
/approve
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matrus2, vladimirvivien The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Hi,
This is hello-world go application template, which will be referenced by flux Kustomization example in #255. This needs to merged first otherwise tests won't pass in corresponding PR.
cc: @harshanarayana @vladimirvivien