Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UltraDNS SDK to v1.3.7 #2859

Closed

Conversation

Volatus
Copy link
Contributor

@Volatus Volatus commented Jul 5, 2022

Description
This PR updates the SDK for UltraDNS as it was outdated by over 2 years. Seems to build and tests pass just fine.
May help issues like #2780 that may be caused by an update to the UltraDNS API which is now v3.

Fixes #2780

Checklist

  • Unit tests updated
  • End user documentation updated

Signed-off-by: Ismayil Mirzali <[email protected]>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 5, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Volatus
To complete the pull request process, please assign njuettner after the PR has been reviewed.
You can assign the PR to them by writing /assign @njuettner in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from Raffo and seanmalloy July 5, 2022 09:42
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 5, 2022
@Volatus
Copy link
Contributor Author

Volatus commented Jul 5, 2022

/kind bug

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jul 5, 2022
@Volatus Volatus mentioned this pull request Jul 5, 2022
@Volatus
Copy link
Contributor Author

Volatus commented Jul 5, 2022

/ok-to-test

@k8s-ci-robot
Copy link
Contributor

@Volatus: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Volatus
Copy link
Contributor Author

Volatus commented Jul 5, 2022

/assign @njuettner

@Volatus
Copy link
Contributor Author

Volatus commented Jul 6, 2022

/hold

It looks like it may be necessary to swap to the new SDK provided by UltraDNS.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 6, 2022
@Volatus
Copy link
Contributor Author

Volatus commented Jul 10, 2022

/close

@k8s-ci-robot
Copy link
Contributor

@Volatus: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecated UltraDns API
3 participants