-
Notifications
You must be signed in to change notification settings - Fork 512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs to use v1beta1 #1238
Update docs to use v1beta1 #1238
Conversation
Welcome @EmilyShepherd! |
Hi @EmilyShepherd. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have enough context to validate the approach here, but I spent some time clicking through the Netlify preview, and it looks correct from what I saw!
Thanks @EmilyShepherd, this is great! Now that I'm realizing that our actual release date is 2 weeks away (July 12), I'm realizing that we could result in a confusing state of our docs if we're not careful. Specifically if our examples all show the
I think 2 is the much safer option. If that makes sense to you, do you mind keeping the last 2 commits of this PR for a later PR that we can merge right after we release v0.5.0? |
/ok-to-test |
If it were one of my own projects, I'd normally just go straight to recommending the latest version, but that is most definately not a call for me to make. So I am therefore more than happy to take the last two commits out and split them into a seperate PR. I'll have to update the api-docs gen code to no longer exclude I'll pull those commits out, make that change (and also do an intermediate repair of "Used By" headers, which will be wrong if we merge just the first few commits in) now. If you would like, I could also amend this PR to still include the dropping of the |
201d9ed
to
0acaed5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really great, thanks @EmilyShepherd! Just a couple nits but otherwise LGTM.
/approve
hack/invalid-examples/v1beta1/httproute/invalid-filter-wrong-field.yaml
Outdated
Show resolved
Hide resolved
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: EmilyShepherd, robscott The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I'd usually agree, but since we still only have a release candidate, we historically have recommended installing the latest stable release until we get another full release out. |
These are `v1beta1` versions of the invalid examples which already exist for `v1alpha2`.
We automatically generate the api docs for the most recent verion of the Gateway API. However, as the documentation refers to both v1beta1 resources, and some resources which have not yet graduted (eg TCPRoutes etc) we have change the api-docs generation to include both.
This change drops the "v1alpha2" file from the documentation site, which will result in it being dropped from the URLs. Symlinks have been put in place to ensure that old-style URLs are still served.
0acaed5
to
bf0b0ca
Compare
Thanks @EmilyShepherd! /lgtm |
[EDIT: In light of @robscott's suggestion, the change of the documentation reference to
v1beta1
has been removed from this PR - all examples will continue to usev1alpha2
for the moment.]What type of PR is this?
/kind documentation
What this PR does / why we need it:
This PR is part of #1229 which requires updating examples and documentation to use the newer
v1beta1
versions of resources, where appropriate. It does the following:hack/invalid-examples
examples/experimental
Updates the documentation to refer to v1beta1 examples were possible.Updates the "Used In" metadata headers in all examples (either by removing them for examples that are no longer used, or by ensuring that their path does not contain the old-style v1alpha2 prefix).Notable points:
hack/api-docs/generate.sh
script had to be refactored slightly to have to generate both versions of the apiapis/docs.go
stub had to be added to get gen-crd-api-reference-docs to recogniseapis
as a go package and therefore scan its subdirectories.Gateway
,GatewayClass
, andHTTPRoute
have been explictly excluded from thev1alpha2
api-docs generation, as they already appear inv1beta1
. It is debatable if this is "correct" behaviour as they do, of course, still exist in thev1alpha2
version, but it felt redundant to include them twice in the docs.Which issue(s) this PR fixes:
Addresses #1229
Does this PR introduce a user-facing change?: