Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix support level for HTTPRequestHeaderFilter #721

Merged

Conversation

hbagdi
Copy link
Contributor

@hbagdi hbagdi commented Jul 13, 2021

What type of PR is this?

/kind bug
What this PR does / why we need it:
As noted in #655, a core filter with extended support fields is
confusing and also seems to be incorrect.
This patch drops the extended field from the filter and is a partial fix
for the referenced issue.

HTTPRequestMirroFilter has not been patch as GEP-718 could potentially
simplify that.
Which issue(s) this PR fixes:

Partial fix for #655

Does this PR introduce a user-facing change?:

bugfix: To avoid confusion, fields within HTTPRequestHeaderFilter are no more marked as 'extended'. All fields must be supported by implementations for this core filter.

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jul 13, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hbagdi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from jpeach and thockin July 13, 2021 23:32
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 13, 2021
@hbagdi hbagdi force-pushed the fix/support-level-header-filter branch from 19c9461 to ff97439 Compare July 13, 2021 23:33
As noted in kubernetes-sigs#655, a core filter with extended support fields is
confusing and also seems to be incorrect.
This patch drops the extended field from the filter and is a partial fix
for the referenced issue.

HTTPRequestMirroFilter has not been patch as GEP-718 could potentially
simplify that.
@hbagdi hbagdi force-pushed the fix/support-level-header-filter branch from ff97439 to 89bc60a Compare July 13, 2021 23:53
@hbagdi
Copy link
Contributor Author

hbagdi commented Jul 14, 2021

/cc @banks @robscott

@k8s-ci-robot k8s-ci-robot requested a review from robscott July 14, 2021 00:01
@k8s-ci-robot
Copy link
Contributor

@hbagdi: GitHub didn't allow me to request PR reviews from the following users: banks.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @banks @robscott

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@robscott
Copy link
Member

Thanks!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 14, 2021
@k8s-ci-robot k8s-ci-robot merged commit 1a7d2b4 into kubernetes-sigs:master Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants