imagebuilder: Add stretch images for 1.16 and 1.17 #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating docker versions, as compared to 1.15
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
justinsb
added a commit
to justinsb/kops
that referenced
this pull request
Jan 17, 2020
* Add 1.16, 1.17 images with correct docker versions (cf kubernetes-sigs/image-builder#127) * Regular package updates on other stretch images
qqshfox
reviewed
Jan 18, 2020
| {{ end }} | ||
|
|
||
| plugins: | ||
| {{ if eq .Cloud "gce" }} |
There was a problem hiding this comment.
Suggest using 169.254.169.123 (Amazon Time Sync Service) on AWS per https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/set-time.html. Then we can close kubernetes/kops#4021.
{{ if eq .Cloud "aws" }}
ntp:
servers:
- 169.254.169.123
{{ else if eq .Cloud "gce" }}
ntp:
servers:
- metadata.google.internal
{{ else }}
ntp: {}
{{ end }}
matt0x6F
pushed a commit
to matt0x6F/kops
that referenced
this pull request
Feb 3, 2020
* Add 1.16, 1.17 images with correct docker versions (cf kubernetes-sigs/image-builder#127) * Regular package updates on other stretch images
|
/lgtm I think as the image has already been built we should merge this, and open a new PR for new changes. |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating docker versions, as compared to 1.15