Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 2404 targets to the OVA and RAW builder and 2204 for RAW #1503

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MaxRink
Copy link
Contributor

@MaxRink MaxRink commented Jul 4, 2024

Change description

This adds Ubuntu 24.04 builds for the OVA and the RAW builder.
It also adds 2204 support for the RAW builder, which was missing before

Related issues

#1406

Additional context

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 4, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jsturtevant for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jul 4, 2024
@MaxRink MaxRink force-pushed the upstream-2404 branch 2 times, most recently from 767cca6 to 1412142 Compare July 4, 2024 09:02
@MaxRink
Copy link
Contributor Author

MaxRink commented Jul 9, 2024

/retest

@drew-viles
Copy link
Contributor

Thanks for this. I'm hapy to test this as the OVA test is optional now due to the infra not being community owned.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jul 24, 2024
@mboersma
Copy link
Contributor

/retest

2404-efi timeout looks like it could be a flake, let's see.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 30, 2024
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Contributor

@MaxRink: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-ova-all ce06092 link false /test pull-ova-all
pull-gcp-all ce06092 link true /test pull-gcp-all

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 13, 2025
@s3rj1k
Copy link
Contributor

s3rj1k commented Jan 14, 2025

@MaxRink Would it be fine if I takeout raw target changes out of this PR to stand-alone PR or maybe you could do it yourself?

(I have a need for this, so can at least test raw target changes manually)

@MaxRink
Copy link
Contributor Author

MaxRink commented Jan 15, 2025

@s3rj1k i can take out the raw targets into a seperate PR, sure

@MaxRink
Copy link
Contributor Author

MaxRink commented Jan 15, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants