Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Namespace from the JobSet Config #752

Conversation

andreyvelich
Copy link
Contributor

@andreyvelich andreyvelich commented Jan 14, 2025

What type of PR is this?

I removed namespace from the JobSet config as we discussed here: #719 (comment)

/kind cleanup
/assign @kannon92 @ahg-g @danielvegamyhre @tenzen-y

What this PR does / why we need it:

The webhook and JobSet controller always have the same namespace, so user should not override this value in the Config.
The namespace is taken from the Pod's service account: /var/run/secrets/kubernetes.io/serviceaccount/namespace

Which issue(s) this PR fixes:

Fixes # #720

Special notes for your reviewer:

Does this PR introduce a user-facing change?

The namespace parameter has been removed from the JobSet manager config.

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jan 14, 2025
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 14, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @andreyvelich. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 14, 2025
Copy link

netlify bot commented Jan 14, 2025

Deploy Preview for kubernetes-sigs-jobset canceled.

Name Link
🔨 Latest commit ace0065
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-jobset/deploys/678697c3dcc8c50008b33170

@kannon92
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 14, 2025
@kannon92
Copy link
Contributor

/assign @ahg-g

We probably should not drop fields from an API without a deprecation process.

I would add a release-note saying that we are dropping this at least.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 14, 2025
@kannon92
Copy link
Contributor

/hold

I want to wait for comments from @danielvegamyhre and @ahg-g.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 14, 2025
@ahg-g
Copy link
Contributor

ahg-g commented Jan 14, 2025

Since this is an alpha API, we can technically change it. While I am ok with doing that for component config API, I think for the JobSet api itself we certainly need a stronger deprecation process where we support both v1alpha2 and v1 at the same time (assuming we go directly to v1)

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, andreyvelich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 14, 2025
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 14, 2025
@kannon92
Copy link
Contributor

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 14, 2025
@k8s-ci-robot k8s-ci-robot merged commit ab38814 into kubernetes-sigs:main Jan 14, 2025
12 checks passed
@andreyvelich andreyvelich deleted the issue-720-drop-namespace-from-config branch January 15, 2025 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants