-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Namespace from the JobSet Config #752
Remove Namespace from the JobSet Config #752
Conversation
Hi @andreyvelich. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for kubernetes-sigs-jobset canceled.
|
/ok-to-test |
/assign @ahg-g We probably should not drop fields from an API without a deprecation process. I would add a release-note saying that we are dropping this at least. |
/hold I want to wait for comments from @danielvegamyhre and @ahg-g. |
Since this is an alpha API, we can technically change it. While I am ok with doing that for component config API, I think for the JobSet api itself we certainly need a stronger deprecation process where we support both v1alpha2 and v1 at the same time (assuming we go directly to v1) /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahg-g, andreyvelich The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold cancel |
What type of PR is this?
I removed namespace from the JobSet config as we discussed here: #719 (comment)
/kind cleanup
/assign @kannon92 @ahg-g @danielvegamyhre @tenzen-y
What this PR does / why we need it:
The webhook and JobSet controller always have the same namespace, so user should not override this value in the Config.
The namespace is taken from the Pod's service account:
/var/run/secrets/kubernetes.io/serviceaccount/namespace
Which issue(s) this PR fixes:
Fixes # #720
Special notes for your reviewer:
Does this PR introduce a user-facing change?