Fix cache syncing causing transient failures (#188)

Makefile

@@ -11,6 +11,15 @@ test: ## Run tests
 		--ginkgo.focus="${FOCUS}" \
 		-cover -coverprofile=coverage.out -outputdir=. -coverpkg=./...
 
+deflake: ## Run randomized, racing tests until the test fails to catch flakes
+	ginkgo \
+		--race \
+		--focus="${FOCUS}" \
+		--randomize-all \
+		--until-it-fails \
+		-v \
+		./pkg/...
+
 verify: ## Verify code. Includes codegen, dependencies, linting, formatting, etc
 	go mod tidy
 	go generate ./...

pkg/controllers/machine/suite_test.go

@@ -52,7 +52,7 @@ var cloudProvider *fake.CloudProvider
 func TestAPIs(t *testing.T) {
 	ctx = TestContextWithLogger(t)
 	RegisterFailHandler(Fail)
-	RunSpecs(t, "Node")
+	RunSpecs(t, "Machine")
 }
 
 var _ = BeforeSuite(func() {

pkg/test/cachesyncingclient.go

@@ -149,11 +149,11 @@ func (c *cacheSyncingStatusWriter) Patch(ctx context.Context, obj client.Object,
 }
 
 func objectSynced(ctx context.Context, c client.Client, obj client.Object) error {
-	stored := obj.DeepCopyObject().(client.Object)
-	if err := c.Get(ctx, client.ObjectKeyFromObject(obj), obj); err != nil {
+	temp := obj.DeepCopyObject().(client.Object)
+	if err := c.Get(ctx, client.ObjectKeyFromObject(obj), temp); err != nil {
 		return fmt.Errorf("getting object, %w", err)
 	}
-	if obj.GetResourceVersion() != stored.GetResourceVersion() {
+	if obj.GetResourceVersion() != temp.GetResourceVersion() {
 		return fmt.Errorf("object hasn't updated")
 	}
 	return nil