-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Remove runtime update of karpenter-global-settings
#174
Merged
jonathan-innis
merged 1 commit into
kubernetes-sigs:main
from
jonathan-innis:remove-runtime-settings-changes
Jan 26, 2023
Merged
chore: Remove runtime update of karpenter-global-settings
#174
jonathan-innis
merged 1 commit into
kubernetes-sigs:main
from
jonathan-innis:remove-runtime-settings-changes
Jan 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathan-innis
force-pushed
the
remove-runtime-settings-changes
branch
5 times, most recently
from
January 24, 2023 21:08
dd133eb
to
fb9354f
Compare
Pull Request Test Coverage Report for Build 4017778981
💛 - Coveralls |
jonathan-innis
force-pushed
the
remove-runtime-settings-changes
branch
5 times, most recently
from
January 24, 2023 21:32
68b3120
to
4604b48
Compare
jonathan-innis
changed the title
chore: Remove runtime resolution of configMap settings
chore: Remove runtime update of configMap settings
Jan 24, 2023
jonathan-innis
changed the title
chore: Remove runtime update of configMap settings
chore: Remove runtime update of Jan 24, 2023
karpenter-global-settings
jonathan-innis
force-pushed
the
remove-runtime-settings-changes
branch
2 times, most recently
from
January 24, 2023 21:59
070e3c8
to
d0055a2
Compare
ellistarn
reviewed
Jan 25, 2023
ellistarn
reviewed
Jan 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you make sure to document in a comment somewhere why we moved to static settings from dynamic settings?
jonathan-innis
force-pushed
the
remove-runtime-settings-changes
branch
from
January 25, 2023 21:09
d0055a2
to
4ecc051
Compare
ellistarn
previously approved these changes
Jan 25, 2023
jonathan-innis
force-pushed
the
remove-runtime-settings-changes
branch
from
January 26, 2023 17:50
4ecc051
to
8c6d459
Compare
ellistarn
approved these changes
Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #154
Description
karpenter-global-settings
settings.Injectable
interface that injects settings into the contextHow was this change tested?
make presubmit
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.