fix: dedupe expiration reconciliations #1794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/M
jmdeal
force-pushed
the
fix/duplicate-expirations
branch
from
2181b20 to
65bd97d
Compare
njtran
reviewed
Oct 31, 2024
jmdeal
force-pushed
the
fix/duplicate-expirations
branch
from
65bd97d to
01726b8
Compare
jmdeal
force-pushed
the
fix/duplicate-expirations
branch
from
01726b8 to
5985623
Compare
Pull Request Test Coverage Report for Build 11619365060Details
💛 - Coveralls |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jmdeal, njtran The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
engedaam
pushed a commit
to engedaam/karpenter-core
that referenced
this pull request
Nov 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #N/A
Description
Currently, the expiration controller reconciles against all NodeClaim updates, and doesn't have a check to ensure that the NodeClaim hasn't already been terminated. This can result in duplicate expiration attempts against the same NodeClaim. The main problem with this (other than unnecessary deletes) is that we increment the expiration metric each time.
This change ensures we don't double count expirations through two mechanisms:
a. Check that the NodeClaim's deletion timestamp is zero before proceeding with expiration.
b. Only enqueue requests for NodeClaims when they are first added to the informer cache.
How was this change tested?
make testBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.