Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move pod ack to when pod is first seen by Karpenter #1871

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

rschalo
Copy link
Contributor

@rschalo rschalo commented Dec 9, 2024

Fixes #N/A

Description
This change includes the time a pod spent waiting for batching in pod scheduling duration.

How was this change tested?
Unit test.

Example in metrics change for single pod:

before moving ackPods
karpenter_pods_scheduling_decision_duration_seconds_bucket{le="0.05"} 0
karpenter_pods_scheduling_decision_duration_seconds_bucket{le="0.1"} 1

after moving ackPods

karpenter_pods_scheduling_decision_duration_seconds_bucket{le="1"} 0
karpenter_pods_scheduling_decision_duration_seconds_bucket{le="1.25"} 1

Moving ackPods has added the 1 second coming from maxIdleBatching to the total time it takes to schedule.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 9, 2024
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 9, 2024
Copy link
Member

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 9, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jonathan-innis, rschalo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 9, 2024
@jonathan-innis
Copy link
Member

/hold

Can you add an example/some data around how this changes our metrics?

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 9, 2024
@coveralls
Copy link

coveralls commented Dec 9, 2024

Pull Request Test Coverage Report for Build 12241208968

Details

  • 4 of 5 (80.0%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.2%) to 80.875%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controllers/controllers.go 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/utils/termination/termination.go 2 92.31%
Totals Coverage Status
Change from base Build 12208826786: 0.2%
Covered Lines: 8948
Relevant Lines: 11064

💛 - Coveralls

@jonathan-innis
Copy link
Member

/unhold

Description was updated and tested

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 10, 2024
@k8s-ci-robot k8s-ci-robot merged commit fd5ddab into kubernetes-sigs:main Dec 10, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants