-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: move pod ack to when pod is first seen by Karpenter #1871
fix: move pod ack to when pod is first seen by Karpenter #1871
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jonathan-innis, rschalo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold Can you add an example/some data around how this changes our metrics? |
Pull Request Test Coverage Report for Build 12241208968Details
💛 - Coveralls |
/unhold Description was updated and tested |
Fixes #N/A
Description
This change includes the time a pod spent waiting for batching in pod scheduling duration.
How was this change tested?
Unit test.
Example in metrics change for single pod:
Moving
ackPods
has added the 1 second coming frommaxIdleBatching
to the total time it takes to schedule.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.