Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Handle insufficient capacity self-delete #208

Merged
merged 1 commit into from
Feb 10, 2023
Merged

chore: Handle insufficient capacity self-delete #208

merged 1 commit into from
Feb 10, 2023

Conversation

jonathan-innis
Copy link
Member

@jonathan-innis jonathan-innis commented Feb 10, 2023 •
edited
Loading

Fixes #

Description

  • Make an Insufficient Capacity Error a cloudprovider-neutral concept as well as ensure that if this error is returned during machine launch that we self-delete so we will go to re-launch

How was this change tested?

make presubmit

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jonathan-innis jonathan-innis requested a review from a team as a code owner February 10, 2023 22:02
@jonathan-innis jonathan-innis enabled auto-merge (squash) February 10, 2023 22:03
@coveralls
Copy link

coveralls commented Feb 10, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4148088220

  • 26 of 34 (76.47%) changed or added relevant lines in 3 files are covered.
  • 7 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.06%) to 78.415%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/cloudprovider/types.go 13 21 61.9%
Files with Coverage Reduction New Missed Lines %
pkg/controllers/node/controller.go 7 73.53%
Totals Coverage Status
Change from base Build 4146535010: 0.06%
Covered Lines: 6274
Relevant Lines: 8001
💛 - Coveralls

bwagner5
bwagner5 approved these changes Feb 10, 2023
View reviewed changes
Copy link
Contributor

@bwagner5 bwagner5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonathan-innis jonathan-innis merged commit f3b4934 into kubernetes-sigs:main Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwagner5 bwagner5 bwagner5 approved these changes

@spring1843 spring1843 Awaiting requested review from spring1843 spring1843 was automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonathan-innis @coveralls @bwagner5