Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add JSON printer column for topology.kubernetes.io/zone #258

Merged
merged 1 commit into from
Mar 31, 2023

Conversation

jonathan-innis
Copy link
Member

Fixes #

Description

Add JSON printer column for topology.kubernetes.io/zone

How was this change tested?

Applying the CRD manually to cluster

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jonathan-innis jonathan-innis requested a review from a team as a code owner March 31, 2023 05:43
@jonathan-innis jonathan-innis requested a review from bwagner5 March 31, 2023 05:43
@jonathan-innis jonathan-innis enabled auto-merge (squash) March 31, 2023 05:44
@coveralls
Copy link

coveralls commented Mar 31, 2023

Pull Request Test Coverage Report for Build 4571977111

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 7 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.09%) to 81.28%

Files with Coverage Reduction New Missed Lines %
pkg/controllers/provisioning/scheduling/preferences.go 7 86.67%
Totals Coverage Status
Change from base Build 4558530184: 0.09%
Covered Lines: 6578
Relevant Lines: 8093

💛 - Coveralls

@jonathan-innis jonathan-innis merged commit c7f3203 into kubernetes-sigs:main Mar 31, 2023
njtran pushed a commit to njtran/karpenter that referenced this pull request Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants