Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix kubeletConfiguration.cpuCFSQuota #274

Merged

Conversation

jonathan-innis
Copy link
Member

@jonathan-innis jonathan-innis commented Apr 5, 2023

Fixes #

Description

  • Fix kubeletConfiguration.cpuFSQuota and its defaulting
  • Changes the value to a *bool so we can differentiate between unset and explicit false

How was this change tested?

  • make presubmit
  • Manual Testing
  • Ensured that upgrading from an older version where the value isn't set results in the same output

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jonathan-innis jonathan-innis marked this pull request as ready for review April 5, 2023 21:56
@jonathan-innis jonathan-innis requested a review from a team as a code owner April 5, 2023 21:56
@jonathan-innis jonathan-innis requested a review from njtran April 5, 2023 21:56
@jonathan-innis jonathan-innis changed the title fix: Fix kubeletConfiguration.cpuFSQuota and its defaulting fix: Fix kubeletConfiguration.cpuCFSQuota and its defaulting Apr 5, 2023
@jonathan-innis jonathan-innis force-pushed the fix-cpu-fs-quota branch 2 times, most recently from ee5bc82 to 90e63d4 Compare April 5, 2023 22:00
@coveralls
Copy link

coveralls commented Apr 5, 2023

Pull Request Test Coverage Report for Build 4639902040

  • 1 of 5 (20.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 81.008%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/apis/v1alpha5/zz_generated.deepcopy.go 1 5 20.0%
Files with Coverage Reduction New Missed Lines %
pkg/controllers/deprovisioning/helpers.go 2 83.04%
Totals Coverage Status
Change from base Build 4620792336: -0.2%
Covered Lines: 6654
Relevant Lines: 8214

💛 - Coveralls

@jonathan-innis jonathan-innis force-pushed the fix-cpu-fs-quota branch 2 times, most recently from 3d32f03 to bea29c4 Compare April 5, 2023 23:37
@jonathan-innis jonathan-innis added the blocked Unable to make progress due to some dependency label Apr 6, 2023
@jonathan-innis jonathan-innis marked this pull request as draft April 6, 2023 18:55
@jonathan-innis jonathan-innis force-pushed the fix-cpu-fs-quota branch 2 times, most recently from 8dfb56e to ba9568d Compare April 7, 2023 16:51
@jonathan-innis jonathan-innis marked this pull request as ready for review April 7, 2023 16:55
@jonathan-innis jonathan-innis force-pushed the fix-cpu-fs-quota branch 2 times, most recently from 0034707 to 5ff9c33 Compare April 7, 2023 16:59
@jonathan-innis jonathan-innis enabled auto-merge (squash) April 7, 2023 17:02
@jonathan-innis jonathan-innis removed the blocked Unable to make progress due to some dependency label Apr 7, 2023
@jonathan-innis jonathan-innis changed the title fix: Fix kubeletConfiguration.cpuCFSQuota and its defaulting fix: Fix kubeletConfiguration.cpuCFSQuota Apr 7, 2023
@jonathan-innis jonathan-innis merged commit 394c11c into kubernetes-sigs:main Apr 7, 2023
njtran pushed a commit to njtran/karpenter that referenced this pull request Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants