Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added metrics for consistency checks #275

Merged
merged 1 commit into from
Apr 7, 2023
Merged

feat: Added metrics for consistency checks #275

merged 1 commit into from
Apr 7, 2023

Conversation

ellistarn
Copy link
Contributor

@ellistarn ellistarn commented Apr 7, 2023 •
edited
Loading

Fixes #3696

Description

Added metrics for consistency checks.

How was this change tested?

karpenter-96d576577-djtgc controller 2023-04-07T17:48:25.908Z	ERROR	controller.consistency	check failed, expected 688 of resource pods, but found 345 (50.1% of expected)	{"commit": "0bcd446-dirty", "node": "ip-192-168-98-227.us-west-2.compute.internal"}

curl localhost:8080/metrics | grep karpenter_consistency_errors
karpenter_consistency_errors{check="NodeShape"} 1

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ellistarn ellistarn requested a review from a team as a code owner April 7, 2023 17:29
@ellistarn ellistarn requested a review from tzneal April 7, 2023 17:29
@ellistarn ellistarn marked this pull request as draft April 7, 2023 17:29
@ellistarn ellistarn force-pushed the 3696 branch 2 times, most recently from a0b1f9b to 53b5d1e Compare April 7, 2023 17:47
@coveralls
Copy link

coveralls commented Apr 7, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4640396027

  • 14 of 19 (73.68%) changed or added relevant lines in 6 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.04%) to 81.098%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controllers/consistency/failedinit.go 2 3 66.67%
pkg/controllers/consistency/controller.go 5 7 71.43%
pkg/controllers/consistency/nodeshape.go 1 3 33.33%
Files with Coverage Reduction New Missed Lines %
pkg/test/cachesyncingclient.go 2 80.41%
Totals Coverage Status
Change from base Build 4640248807: -0.04%
Covered Lines: 6663
Relevant Lines: 8216
💛 - Coveralls

jonathan-innis
jonathan-innis reviewed Apr 7, 2023
View reviewed changes
pkg/controllers/consistency/metrics.go Outdated Show resolved Hide resolved
pkg/controllers/consistency/nodeshape.go Outdated Show resolved Hide resolved
pkg/controllers/consistency/nodeshape.go Show resolved Hide resolved
pkg/controllers/consistency/events.go Outdated Show resolved Hide resolved
@ellistarn ellistarn force-pushed the 3696 branch 3 times, most recently from bae32a6 to e09bef9 Compare April 7, 2023 18:14
@ellistarn ellistarn marked this pull request as ready for review April 7, 2023 18:18
@ellistarn ellistarn enabled auto-merge (squash) April 7, 2023 18:32
jonathan-innis
jonathan-innis approved these changes Apr 7, 2023
View reviewed changes
Copy link
Member

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@ellistarn ellistarn merged commit 7a015fc into kubernetes-sigs:main Apr 7, 2023
@ellistarn ellistarn deleted the 3696 branch April 7, 2023 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathan-innis jonathan-innis jonathan-innis approved these changes

@tzneal tzneal Awaiting requested review from tzneal tzneal was automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ellistarn @coveralls @jonathan-innis