Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: only log after cordon succeeds #296

Merged
merged 1 commit into from
Apr 17, 2023
Merged

fix: only log after cordon succeeds #296

merged 1 commit into from
Apr 17, 2023

Conversation

njtran
Copy link
Contributor

@njtran njtran commented Apr 17, 2023

Fixes #

Description
If the cordon in a termination reconcile failed, we would still log as cordoned.

How was this change tested?
make presubmit

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@njtran njtran requested a review from a team as a code owner April 17, 2023 22:46
@njtran njtran requested a review from tzneal April 17, 2023 22:46
@njtran njtran enabled auto-merge (squash) April 17, 2023 22:47
jonathan-innis
jonathan-innis approved these changes Apr 17, 2023
View reviewed changes
Copy link
Member

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@coveralls
Copy link

coveralls commented Apr 17, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4726569363

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 8 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.06%) to 81.399%
Files with Coverage Reduction New Missed Lines %
pkg/controllers/termination/terminator/terminator.go 1 92.59%
pkg/controllers/deprovisioning/helpers.go 2 83.64%
pkg/test/cachesyncingclient.go 2 80.41%
pkg/controllers/node/controller.go 3 79.41%
Totals Coverage Status
Change from base Build 4721319982: -0.06%
Covered Lines: 6761
Relevant Lines: 8306
💛 - Coveralls

@njtran njtran merged commit ab4eccc into kubernetes-sigs:main Apr 17, 2023
njtran added a commit to njtran/karpenter that referenced this pull request Apr 18, 2023
@njtran
only log after cordon succeeds (kubernetes-sigs#296)
93e63b2
@njtran njtran deleted the propercordon branch April 18, 2023 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathan-innis jonathan-innis jonathan-innis approved these changes

@tzneal tzneal Awaiting requested review from tzneal tzneal was automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@njtran @coveralls @jonathan-innis