-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC: Propose minValues
to enforce Flexibility on NodeClaim Requests
#966
RFC: Propose minValues
to enforce Flexibility on NodeClaim Requests
#966
Conversation
af2fd6d
to
93755c2
Compare
93755c2
to
e28b01e
Compare
Pull Request Test Coverage Report for Build 7806548238Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My thoughts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, good design, we've already synced on most of my thoughts in the doc, but just posting them here for posterity
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jonathan-innis, njtran The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #N/A
Description
This RFC proposes a change where users can pass through
minValues
into their different requirement block keys to ensure that Karpenter maintains their request minimum flexibility requirements as it is scheduling pods to nodes. This is useful to maintain spot flexibility when Karpenter is launching new nodes.How was this change tested?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.