Base image updates #1366
Base image updates #1366
Conversation
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
BenTheElder
requested review from
amwat and
aojea
and removed request for
munnerz and
krzyzacy
| @@ -42,7 +42,7 @@ import ( | |||
| const DefaultImage = "kindest/node:latest" | |||
|
|
|||
| // DefaultBaseImage is the default base image used | |||
| const DefaultBaseImage = "kindest/base:v20200221-f3727da0@sha256:a9da2114e7ea293d9ac544a0c5b58d63e5ee44b4e76891bf35671fb1f5ffc611" | |||
| const DefaultBaseImage = "kindest/base:v20200226-6d5ec59c@sha256:7fbe0890dab2dfb170fef3bf8ca8dda9bae40c66e6124a59ce2fd2debd18e818" | |||
There was a problem hiding this comment.
you cannot browse the digest on docker hub, but the tag is browsable, so we include both.
this is the digest of a manifest list for linux/amd64 + linux/arm64
|
/retest
…On Wed, Feb 26, 2020, 18:40 Kubernetes Prow Robot ***@***.***> wrote:
@BenTheElder <https://github.com/BenTheElder>: The following test *failed*,
say /retest to rerun all failed tests:
Test name Commit Details Rerun command
pull-kind-conformance-parallel-1-13 207fd85
<207fd85>
link
<https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/sigs.k8s.io_kind/1366/pull-kind-conformance-parallel-1-13/1232852470992998400/> /test
pull-kind-conformance-parallel-1-13
Full PR test history
<https://prow.k8s.io/pr-history?org=kubernetes-sigs&repo=kind&pr=1366>. Your
PR dashboard <https://gubernator.k8s.io/pr/BenTheElder>. Please help us
cut down on flakes by linking to
<https://git.k8s.io/community/contributors/devel/sig-testing/flaky-tests.md#filing-issues-for-flaky-tests>
an open issue
<https://github.com/kubernetes-sigs/kind/issues?q=is:issue+is:open> when
you hit one in your PR.
Instructions for interacting with me using PR comments are available here
<https://git.k8s.io/community/contributors/guide/pull-requests.md>. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
<https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:>
repository. I understand the commands that are listed here
<https://go.k8s.io/bot-commands>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1366?email_source=notifications&email_token=AAHADKYVFJLLIWFJQJWAJFLRE4RYBA5CNFSM4K4SBSD2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENCWCBI#issuecomment-591749381>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHADKZ5I64DXT26IT25WMLRE4RYBANCNFSM4K4SBSDQ>
.
|
| IMAGE?=kindest/base:$(TAG) | ||
|
|
||
| # build with buildx | ||
| PLATFORMS?=linux/amd64,linux/arm64 |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
Cool |
|
FYI @neolit123 |
|
ack, thanks for the heads up. |
|
shouldn't affect anything I think, BUT it is a manifest list image instead now, and it does mean some movement towards arm being a thing. I'm guessing kinder users are all amd64 but I wouldn't be too surprised if someone was trying to use another architecture 😅 |
|
(and the image build is changing, we really need to remove |
|
we have quite a few amd64 jobs for kinder right now and the amd64 assumptions are hardcoded. i'm hoping that one day we will be able to run at least one arm64 job too. since we don't have a way to provision arm64 with prow today (AFAIK), i was wondering if its possible to try it in github actions, by requesting a non-amd64 VM in the workflow job and running kind/kinder there with k8s non-amd64 artifacts. but this has been in the backlog, due to other priorities. |
|
Ack, thanks for the details! I'll follow up on this in the future.
…On Thu, Feb 27, 2020, 11:15 Lubomir I. Ivanov ***@***.***> wrote:
we have quite a few amd64 jobs for kinder right now and the amd64
assumptions are hardcoded.
i'm hoping that one day we will be able to run at least one arm64 job too.
since we don't have a way to provision arm64 with prow today (AFAIK), i
was wondering if its possible to try it in github actions, by requesting
a non-amd64 VM in the workflow job
<https://github.com/uraimo/run-on-arch-action#optional-parameters> and
running kind/kinder there with k8s non-amd64 artifacts.
but this has been in the backlog, due to other priorities.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1366?email_source=notifications&email_token=AAHADK6TKI6WX7MKGG7N5KTRFAGMDA5CNFSM4K4SBSD2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENFS3OY#issuecomment-592129467>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHADKZS33G35LXKB3FTUB3RFAGMDANCNFSM4K4SBSDQ>
.
|
|
Looks like that action is just a qemu wrapper, the performance will probably be too bad. Travis has ACTUAL arm IIRC but getting it in k8s may be hard. |
i didn't know it is using emulation. this might be quite slow, indeed. |
|
locally using qemu to build the image is pretty slow, and I'm betting the actions workers are much smaller machines. |
ref: ARM64 CI #188 Support arm64 #166 Getting Kind works on ARM64 #1347 ...
this is much slower and problematic to locally test (the manifest list cannot be exported to local, so you need to do a quick build and test that) but, it is feasible. starting with just amd64 and arm64.