base-image: inherit the host environment when building #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With modules enabled in the repo and without this change, errors are thrown when building the base image - e.g. for GOCACHE or HOME not being defined. Inherit the host environment when calling `go build` for the entry point binary.
k8s-ci-robot
added
kind/bug
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
do-not-merge/hold
BenTheElder
approved these changes
Feb 25, 2019
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder, neolit123 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
yes,
|
|
Thanks! |
k8s-ci-robot
removed
the
do-not-merge/hold
stg-0
pushed a commit
to stg-0/kind
that referenced
this pull request
Nov 20, 2023
* Fix release 0.3 images Documentation * Fix release 0.3 images Documentation * Fix crictl versions * Fix GCP Image documentation * Fix GCP Image documentation & improve AWS image doc * Fix installation.adoc dead page link * Fix installation.adoc dead page link gcp * Remove old files * Fix Docs Checks Orphan Assets * Fix Doc * Fix Docs Checks - Empty lines * Fix ECR docs * Fix typo * Apply suggested changes * Fix merge * More fixes * Fix empty line * Remove empty lines * More fixes --------- Co-authored-by: Francisco Augusto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With modules enabled in the repo and without this change,
errors seem to be thrown when building the base image - e.g. for
GOCACHE or HOME not being defined.
Inherit the host environment when calling
go buildfor the entry point binary.
golang/go#29267
/kind bug
/priority important-longterm