Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump base image #3521

Merged
merged 3 commits into from
Feb 14, 2024
Merged

bump base image #3521

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
335a10c
bump base image
BenTheElder Feb 13, 2024
3e2765a
drop creating /kind dir at node-image build time
BenTheElder Feb 13, 2024
455f9e7
bump node image
BenTheElder Feb 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/apis/config/defaults/image.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,4 @@ limitations under the License.
package defaults

// Image is the default for the Config.Image field, aka the default node image.
const Image = "kindest/node:v1.29.1@sha256:a0cc28af37cf39b019e2b448c54d1a3f789de32536cb5a5db61a49623e527144"
const Image = "kindest/node:v1.29.1@sha256:0c06baa545c3bb3fbd4828eb49b8b805f6788e18ce67bff34706ffa91866558b"
7 changes: 0 additions & 7 deletions pkg/build/nodeimage/buildcontext.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,13 +96,6 @@ func (c *buildContext) buildImage(bits kube.Bits) error {

c.logger.V(0).Info("Building in container: " + containerID)

// make artifacts directory
// TODO: remove this after the next release, we pre-create this in the base image now
if err = cmder.Command("mkdir", "-p", "/kind/").Run(); err != nil {
c.logger.Errorf("Image build Failed! Failed to make directory %v", err)
return err
}

// copy artifacts in
for _, binary := range bits.BinaryPaths() {
// TODO: probably should be /usr/local/bin, but the existing kubelet
Expand Down
2 changes: 1 addition & 1 deletion pkg/build/nodeimage/defaults.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,4 @@ const DefaultImage = "kindest/node:latest"
// DefaultBaseImage is the default base image used
// TODO: come up with a reasonable solution to digest pinning
// https://github.com/moby/moby/issues/43188
const DefaultBaseImage = "docker.io/kindest/base:v20240202-8f1494ea"
const DefaultBaseImage = "docker.io/kindest/base:v20240212-c4cadcab"
Loading