Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checks for annotation for objects in-cluster #111

Merged
merged 3 commits into from
Aug 11, 2020
Merged

Checks for annotation for objects in-cluster #111

merged 3 commits into from
Aug 11, 2020

Conversation

somtochiama
Copy link
Member

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 20, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @somtochiama. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Jul 20, 2020
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 20, 2020
justinsb
justinsb reviewed Jul 21, 2020
View reviewed changes
pkg/patterns/declarative/reconciler.go Outdated
@@ -134,6 +136,40 @@ func (r *Reconciler) reconcileExists(ctx context.Context, name types.NamespacedN
if err != nil {
return reconcile.Result{}, err
}

// dynamic config
dynamicClientset, err := dynamic.NewForConfig(r.config)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may want to construct this earlier and cache it in the Reconciler object; though it doesn't matter as much for the dynamic client which doesn't have as much state.

pkg/patterns/declarative/reconciler.go Outdated

// Uses unsafe method?? Is it safe?
getOptions := metav1.GetOptions{}
gvk, _ := meta.UnsafeGuessKindToResource(obj.GroupVersionKind())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: rename gvk to resource or similar

pkg/patterns/declarative/reconciler.go Outdated
newItems := []*manifest.Object{}
for _, obj := range objects.Items {

// Uses unsafe method?? Is it safe?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can use RESTMapping, like here https://github.com/kubernetes-sigs/kubebuilder-declarative-pattern/blob/master/pkg/patterns/declarative/pkg/watch/dynamic.go#L64

pkg/patterns/declarative/reconciler.go Show resolved Hide resolved
pkg/patterns/declarative/reconciler.go Outdated Show resolved Hide resolved
pkg/patterns/declarative/reconciler.go Outdated Show resolved Hide resolved
pkg/patterns/declarative/reconciler.go Outdated Show resolved Hide resolved
@somtochiama somtochiama requested a review from justinsb July 22, 2020 11:10
justinsb
justinsb reviewed Jul 27, 2020
View reviewed changes
pkg/patterns/declarative/reconciler.go Outdated

getOptions := metav1.GetOptions{}
gvk := obj.GroupVersionKind()
restMapper, err := apiutil.NewDiscoveryRESTMapper(r.config)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As with the other PR, probably caching this (like you do dynamicClient) is a win

@justinsb
Copy link
Contributor

/ok-to-test

/approve
/lgtm

One potential improvement: caching the RESTMapper, but LGTM!

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 27, 2020
@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 27, 2020
@atoato88 atoato88 mentioned this pull request Jul 29, 2020
Closed
@justinsb
Copy link
Contributor

/test pull-declarative-test

(The tests aren't failing for me locally, so not sure what's going on)

The goimports failure does look legitimate, though

@justinsb
Copy link
Contributor

Ah: It should be apierrors, when you rebase on latest origin/master the tests do fail.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 31, 2020
@somtochiama somtochiama requested a review from justinsb July 31, 2020 18:40
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 10, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 10, 2020
@justinsb
Copy link
Contributor

Looks good - I think all your PRs are overlapping with each other, and this one is now failing on the goimports check!

/approve
/lgtm

(though you'll need to fix the test anyway)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 11, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, SomtochiAma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit eea60d7 into kubernetes-sigs:master Aug 11, 2020
@somtochiama somtochiama mentioned this pull request Aug 14, 2020
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atoato88 atoato88 Awaiting requested review from atoato88

@monopole monopole Awaiting requested review from monopole

@justinsb justinsb Awaiting requested review from justinsb

Assignees

@justinsb justinsb

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@somtochiama @k8s-ci-robot @justinsb