This repository has been archived by the owner on Apr 25, 2023. It is now read-only.
chore: improve some of the deployment and build scripts #1324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* deploy-kubefed.sh: new envvar `NO_JOIN_HOST_CLUSTER`. When set to a non-empty value prevents the script from joining the host cluster to itself. Default behaviour doesn't change. * sync-up-helm-charts.sh: reduced verbosity of the script by letting etcd and kube-apiserver log into files instead of stdout/stderr. This should make it much easier to follow the steps the scripts is exercising. Also improved the two messages printed when waiting for etcd and kube-apiserver to get ready.
k8s-ci-robot
added
cncf-cla: yes
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jimmidyson, makkes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
NO_JOIN_HOST_CLUSTER. When set to anon-empty value prevents the script from joining the host cluster to
itself. Default behaviour doesn't change.
etcd and kube-apiserver log into files instead of stdout/stderr.
This should make it much easier to follow the steps the scripts is
exercising. Also improved the two messages printed when waiting for
etcd and kube-apiserver to get ready.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):n/a
Special notes for your reviewer:
No behaviour has been changed with respect to what the scripts do but only to how much information they log to stdout.