-
Notifications
You must be signed in to change notification settings - Fork 533
fixed false api resource error log in kubefedctl #1410
fixed false api resource error log in kubefedctl #1410
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @arriqaaq! |
/assign @hectorj2f |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm but please sign the CLA and fix the email address used in the commits.
/check-cla |
Thank you @makkes, just fixed the cla issue |
/lgtm |
/cc @hectorj2f could you please approve, if you think this change helps? |
/assign @jimmidyson |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: arriqaaq, hectorj2f, makkes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This PR fixes a logging issue when a resource is enabled using the kubefedctl command. The API output is misleading when there are no errors present.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer: