build: Switch to Github Actions from Travis #1420
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
| after_success: | ||
| - test $DOC_ONLY && echo "Skipped!" || make push |
There was a problem hiding this comment.
This path isn't reflect in the GitHub Actions workflow above. Given the Makefile reads the TRAVIS_PULL_REQUEST environment variable in the push target, I take it we need to rework that a bit. My preference would be to just push anytime the target is called and only call that on: push.tags. wdyt?
There was a problem hiding this comment.
Done in 77a49de (i hope!)
.github/workflows/pr-workflow.yml
Outdated
| @@ -0,0 +1,25 @@ | |||
| name: PR build | |||
|
|
|||
| on: [pull_request] | |||
There was a problem hiding this comment.
This might pose a problem as GitHub Actions workflows triggered from forks do not have access to secrets: https://github.blog/2020-08-03-github-actions-improvements-for-fork-and-pull-request-workflows/#improvements-for-public-repository-forks
Solution:
| on: [pull_request] | |
| on: [pull_request_target] |
There was a problem hiding this comment.
I don't think this will work because this runs in the context of the base branch - it's only used for labelling, commenting, etc. not running code from an untrusted fork.
There was a problem hiding this comment.
pull_request_target doesn't use the pull request code though from what i've read, so it doesn't open up security issues. i'm hoping that github actions run on servers that have no pull rate limiting 🤞
There was a problem hiding this comment.
actions/runner-images#1445 explains that GitHub actions have no pull limit (agreement with docker hub) so no need to login.
k8s-ci-robot
added
size/L
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jimmidyson, makkes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm I believe there's no other way than to try it out. 🙂 |
What this PR does / why we need it:
This PR switches from Travis to Github Actions for PR builds - travis-ci.org is shutting down and migrating to travis-ci.com is equivalent effort to switching to Github Actions, which supposedly members have had a better experience with.
Which issue(s) this PR fixes
Fixes #1419
Special notes for your reviewer:
Need to test this PR somehow - hope that pushing it triggers Github Actions.