Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add After=dbus.service to containerd.service #11769

Closed
yankay opened this issue Dec 5, 2024 · 3 comments · Fixed by #11781
Closed

Add After=dbus.service to containerd.service #11769

yankay opened this issue Dec 5, 2024 · 3 comments · Fixed by #11781
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.

Comments

@yankay
Copy link
Member

yankay commented Dec 5, 2024

What would you like to be added

Like: containerd/containerd#10798

Add it to https://github.com/kubernetes-sigs/kubespray/blob/master/roles/container-engine/containerd/templates/containerd.service.j2

Why is this needed

containerd launches runc, which communicates via dbus with systemd to start transient units. Thus, containerd should have an After dependency on dbus.service to prevent dbus from being shut down concurrently with containerd.

@yankay yankay added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. labels Dec 5, 2024
@yankay
Copy link
Member Author

yankay commented Dec 5, 2024

Pending the discussion of containerd/containerd#10798 (comment)

@VannTen
Copy link
Contributor

VannTen commented Dec 5, 2024

I think @champtar is right. dbus is pretty essential to systemd operation, and unless you opt out of the defaults dependency because you're an early boot service, you don't need to care about that (honestly, the local-fs.target and network.target might also be overkill)

@VannTen
Copy link
Contributor

VannTen commented Dec 5, 2024

Yeah local-fs.target is implied by basic.target (see man 7 bootup)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants