containerd: add After=dbus.service #11781
Conversation
This is needed for shutdown ordering: while at startup, it's not a problem that containerd start before dbus (the dbus socket already exists) it needs to shutdown before dbus to do its cleanup (asking systemd via dbus to cleanup cgroups).
k8s-ci-robot
added
release-note-none
|
/ok-to-test |
k8s-ci-robot
added
approved
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mzaian, VannTen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherrypick release-2.24 |
|
@mzaian: new pull request created: #11782 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@mzaian: new pull request created: #11783 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@mzaian: new pull request created: #11784 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This is needed for shutdown ordering: while at startup, it's not a problem that containerd start before dbus (the dbus socket already exists) it needs to shutdown before dbus to do its cleanup (asking systemd via dbus to cleanup cgroups).
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This is needed for shutdown ordering: while at startup, it's not a
problem that containerd start before dbus (the dbus socket already
exists) it needs to shutdown before dbus to do its cleanup (asking
systemd via dbus to cleanup cgroups).
Which issue(s) this PR fixes:
Fixes #11769
Special notes for your reviewer:
xref: containerd/containerd#10798 (comment)
Does this PR introduce a user-facing change?: