-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for configuring nat outgoing ipv6 #10866
Add documentation for configuring nat outgoing ipv6 #10866
Conversation
Hi @anders-elastisys. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
We should rather add the value alongside |
@VannTen have it in both? The reason for this PR is to have it documented somewhere, preferably in a markdown file so that is easier to find and to know how to configure. But I agree, it should be defined in the role as well, I will add it. |
On Thu, Feb 01, 2024 at 06:34:56AM -0800, anders-elastisys wrote:
@VannTen have it in both? The reason for this PR is to have it documented somewhere, preferably in a markdown file so that is easier to find and to know how to configure. But I agree, it should be defined in the role as well, I will add it.
Well in that case the comment in yaml and the markdown says essentially the same thing (duplication tends to bother me a bit^). My opinion
is that we should have "guides" in docs/ and the defaults roles should be automatically assembled into a "reference" documentation (see
#10697) ; but it's not exactly that way currently. Oh well.
/lgtm
|
/ok-to-test |
f0d156a
to
e48bf27
Compare
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Can you also add this to inventory/sample/group_vars/k8s_cluster/k8s-net-calico.yml
?
# Enables Internet connectivity from containers
# nat_outgoing: true
# nat_outgoing_ipv6: false
e48bf27
to
484ee55
Compare
@cyclinder added now, PTAL |
/hold cancel |
Thanks /lgtm |
Thanks @anders-elastisys @VannTen @cyclinder |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anders-elastisys, yankay The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
The variable
nat_outgoing_ipv6
is not documented anywhere, and it needs to be enabled if you want outgoing ipv6 traffic from pods.Also fixed the value set for
calico_vxlan_mode_ipv6
.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: