Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]bump gateway_api_version to v1.2.0 #11636

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −1
Open

[WIP]bump gateway_api_version to v1.2.0 #11636

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion roles/kubernetes-apps/gateway_api/defaults/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
---
gateway_api_enabled: false
gateway_api_version: v1.1.0
gateway_api_version: v1.2.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wrote this code at the beginning, only change this is useless, in order to support offline installation, I finally did not use to this variable (PR #11376), I hope that the version can be differentiated by folder.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reminding.

  1. I do not understand how the support of offline installation affects this variable.
  2. And how should I do to upgrade gateway_api. Should v1.1.0 be retained after updating?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can refer #11376.
My imagination is that you could put the original Gateway API CRDs in the v1.1.0 folder, and you create a separate v1.2.0 folder for the new version, and then you could use the gateway_api_version.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, difference gateway-api version by folder is not very good for scaling. We can't add a directory for every version because the list will be very long after later versions.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because Gateway API release cycle is not very frequent, reserve 3 patch version I think it's appropriate.
If you have a better idea, you can suggest in a comment.

gateway_api_experimental_channel: false