apiserver: fix incorrect path to admission plugins config files #11779
Conversation
k8s-ci-robot
added
release-note
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: VannTen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/ok-to-test |
k8s-ci-robot
added
approved
|
/cherrypick release-2.26 |
|
@VannTen: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Thanks @VannTen |
k8s-ci-robot
added
the
lgtm
|
@VannTen: new pull request created: #11800 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@VannTen: new pull request created: #11801 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@VannTen: new pull request created: #11802 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| @@ -4,6 +4,6 @@ plugins: | |||
| {% for plugin in kube_apiserver_enable_admission_plugins %} | |||
| {% if plugin in kube_apiserver_admission_plugins_needs_configuration %} | |||
| - name: {{ plugin }} | |||
| path: {{ kube_config_dir }}/{{ plugin | lower }}.yaml | |||
| path: {{ kube_config_dir }}/admission-controls/{{ item | lower }}.yaml.yaml | |||
There was a problem hiding this comment.
I think item is undefined, shouldn't that still be plugin? I'm not sure that .yaml.yaml was intentional either.
Also, did this path really need to be updated to fix anything? I believe the following extraVolumes mount configuration is configured in the kubeadm-config files for the admission-controls hostPath directory, which mounted the plugin files in {{ kube_config_dir }}/{{ plugin | lower }}.yaml within the kube-apiserver container before this PR was merged:
- name: admission-control-configs
hostPath: {{ kube_config_dir }}/admission-controls
mountPath: {{ kube_config_dir }}
readOnly: false
pathType: DirectoryOrCreateI think configuring {{ kube_config_dir }}/admission-controls/ is a worthwhile change, but the extraVolumes entry would also need to be updated for this to work.
There was a problem hiding this comment.
Yes, you're perfectly right. I totally forgot that the control plane was in pods, when doing that, + the double extension is obviously wrong...
Should have added a reproducer first 😬
…es (kubernetes-sigs#11779)" This reverts commit 742409e.
…es (kubernetes-sigs#11779)" This reverts commit 742409e.
…es (kubernetes-sigs#11779)" This reverts commit 742409e.
…es (kubernetes-sigs#11779)" This reverts commit 742409e.
…es (kubernetes-sigs#11779)" This reverts commit 742409e.
…es (#11779)" (#11812) This reverts commit 742409e. Co-authored-by: Max Gautier <[email protected]>
…es (#11779)" (#11811) This reverts commit 742409e. Co-authored-by: Max Gautier <[email protected]>
…es (kubernetes-sigs#11779)" (kubernetes-sigs#11808) This reverts commit 742409e.
What type of PR is this?
/kind bug
Which issue(s) this PR fixes:
Fixes #11733
Does this PR introduce a user-facing change?: