use kube-vip image with iptables command

[KubeKyrie]

What type of PR is this?
/kind bug

What this PR does / why we need it:
Kube-vip has two image version, one with iptables command and one not. Everything else is the same.
See https://github.com/kube-vip/kube-vip/pkgs/container/kube-vip-iptables
And we 'd better use kube-vip-iptables.

Which issue(s) this PR fixes:
Fixes #
Fix the iptables command not dound.

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Update kube-vip image with iptables command

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: KubeKyrie
Once this PR has been reviewed and has the lgtm label, please assign floryut for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Hi @KubeKyrie. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[tico88612]

/ok-to-test

[tico88612]

You are changing the default value.
Is there a reason other than fixing the iptables command not found?

[KubeKyrie]

You are changing the default value. Is there a reason other than fixing the iptables command not found?

@tico88612 No other reasons. Just for we could use iptables command.

[yankay]

You are changing the default value. Is there a reason other than fixing the iptables command not found?

@tico88612 No other reasons. Just for we could use iptables command.

HI @KubeKyrie

If changing the default values is not absolutely necessary, we propose adding documentation to clarify the current defaults instead. This approach would help maintain consistency while providing users with the information they need.

[KubeKyrie]

Hi @yankay @tico88612 , sorry for I maybe didn't make myself clear. One truth is that kube-vip with iptables is necessary since kube-vip v0.8.0, and this is introduced by default forward mode masquerade in kube-vip/kube-vip#782.

Otherwise kube-vip controller did not work normally and we must manually change the image. So I think this is a bug-fix, not change of default value. Thanks.

[tico88612]

One truth is that kube-vip with iptables is necessary since kube-vip v0.8.0, and this is introduced by default forward mode masquerade in kube-vip/kube-vip#782.

Otherwise kube-vip controller did not work normally and we must manually change the image. So I think this is a bug-fix, not change of default value. Thanks.

This still sounds weird.
If iptables were required, they would just be installed inside and there would be no need to separate them.
There is no image change upstream, so there should be some other reason why iptables would be needed.

I've been looking through the documentation and it seems to be related to kube-vip Egress, or maybe it's related to the user's operating system (some systems like RHEL and Rocky Linux have deprecated iptables in favor of nftables).

I think a better solution would be to just switch the desired image with a variable instead of changing the default image.
wdyt?

[KubeKyrie]

I think a better solution would be to just switch the desired image with a variable instead of changing the default image. wdyt?

OK, that makes sense.