-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reorganize var defaults #11840
base: master
Are you sure you want to change the base?
reorganize var defaults #11840
Conversation
Signed-off-by: KubeKyrie <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: KubeKyrie The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @KubeKyrie. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Unless this is taking care of all the instances ( I don't think so ? ) please remove the `fixes` to avoid auto closing the issue.
Also, I don't think we should have null checksum, we should rather figure out how to obtain the correct ones.
/ok-to-test
|
What type of PR is this?
/kind flake
What this PR does / why we need it:
reorganize var defaults, and have a default value defined only once
Which issue(s) this PR fixes:
#11822
Special notes for your reviewer:
Does this PR introduce a user-facing change?: