Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added azure_cloud parameter to Azure's cloud_config #6321

Merged
merged 1 commit into from
Jun 25, 2020
Merged

added azure_cloud parameter to Azure's cloud_config #6321

merged 1 commit into from
Jun 25, 2020

Conversation

widgetpl
Copy link
Contributor

/sig cloud-provider

What type of PR is this?

/kind documentation

What this PR does / why we need it:

There is a lack of "cloud" parameter in Azure's cloud_config which is needed in deployments on which Azure Stack we deploy.
This causes issues with csi drivers which needs to communicate with proper API endpoints.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

I think it's quite critical as it makes wrong configuration for Azure's cloud_config.

Does this PR introduce a user-facing change?:
NONE

@k8s-ci-robot k8s-ci-robot added sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 25, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @widgetpl!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 25, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @widgetpl. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot requested review from EppO and holmsten June 25, 2020 06:56
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 25, 2020
@widgetpl
Copy link
Contributor Author

/assign @mattymo

@widgetpl
Copy link
Contributor Author

I am just thinking if this PR should be made to release branches also as it affects them as well.

@widgetpl widgetpl force-pushed the add_cloud_parameter branch from 107d1bc to 2ede317 Compare June 25, 2020 07:09
@floryut
Copy link
Member

floryut commented Jun 25, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 25, 2020
@widgetpl
Copy link
Contributor Author

@floryut can I push it to release branches also as I am using 2.11 right now?

@floryut
Copy link
Member

floryut commented Jun 25, 2020

@floryut can I push it to release branches also as I am using 2.11 right now?

Yes you need to create PR for that, if you can put "[2.x]" in the title to quickly identify them :)

@Miouge1
Copy link
Contributor

Miouge1 commented Jun 25, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Miouge1, widgetpl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 25, 2020
@widgetpl
Copy link
Contributor Author

I have created new PRs for 2.11, 2.12 and 2.13

@widgetpl
Copy link
Contributor Author

#6326

@widgetpl widgetpl mentioned this pull request Jun 25, 2020
Closed
@cheftako
Copy link

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 25, 2020
@k8s-ci-robot k8s-ci-robot merged commit 8ca2a9a into kubernetes-sigs:master Jun 25, 2020
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jun 29, 2020
@widgetpl @LuckySB
added azure_cloud parameter to Azure's cloud_config (kubernetes-sigs#…
41ecddd 
…6321)
erulabs added a commit to kubesail/kubespray that referenced this pull request Jun 30, 2020
@erulabs
Merge branch 'master' of https://github.com/kubernetes-sigs/kubespray
9edd12d 
* 'master' of https://github.com/kubernetes-sigs/kubespray: (22 commits)
  Remove runtime-config from kubeadm if empty (kubernetes-sigs#6311)
  Update deprecated api (kubernetes-sigs#6245)
  Update kube-router to 1.0.0 (kubernetes-sigs#6211)
  Fix kubelet cgroup driver detection for crio (kubernetes-sigs#6331)
  Update hashes and set default version to 1.18.5 (kubernetes-sigs#6335)
  Change MetalLB to one of addons (kubernetes-sigs#6238)
  Update calico to 1.15.0 + minor update to kube-ovn/weave (kubernetes-sigs#6306)
  Add .editorconfig file (kubernetes-sigs#6307)
  Use NetworkManager to manage resolv.conf in FedoraCoreOS (kubernetes-sigs#6291)
  Add USE_REAL_HOSTNAME to inventory.py (kubernetes-sigs#6293)
  Cleanup OpenStack network things (kubernetes-sigs#6283)
  Add support for dns_etchosts (kubernetes-sigs#6236)
  kube_encryption_resources must be output as yaml (kubernetes-sigs#6309)
  Gather ansible_default_ipv4 for specific groups (kubernetes-sigs#6318)
  added azure_cloud parameter to Azure's cloud_config (kubernetes-sigs#6321)
  Fix some doc links (kubernetes-sigs#6328)
  Use `connection: local` when `delegate_to: localhost` (kubernetes-sigs#6322)
  Add /dev volume (kubernetes-sigs#6319)
  Update cilium to 1.8.0 (kubernetes-sigs#6314)
  fix use of ansible tags (kubernetes-sigs#6316)
  ...
@Miouge1 Miouge1 mentioned this pull request Jul 2, 2020
Merged
@floryut floryut mentioned this pull request Aug 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EppO EppO Awaiting requested review from EppO

@holmsten holmsten Awaiting requested review from holmsten

Assignees

@cheftako cheftako

@mattymo mattymo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@widgetpl @k8s-ci-robot @floryut @Miouge1 @cheftako @mattymo