Move to Ansible 3.4.0 #7672
Merged
Move to Ansible 3.4.0 #7672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/feature
|
Hi @cristicalin. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
needs-ok-to-test
k8s-ci-robot
added
the
size/XS
k8s-ci-robot
added
size/S
cristicalin
changed the title
k8s-ci-robot
added
do-not-merge/work-in-progress
cristicalin
force-pushed
the
ansible_2.10
branch
5 times, most recently
from
c9d9f2d to
3356744
Compare
k8s-ci-robot
added
size/L
cristicalin
force-pushed
the
ansible_2.10
branch
7 times, most recently
from
9c36252 to
2c7c0a8
Compare
k8s-ci-robot
added
the
lgtm
cristicalin
force-pushed
the
ansible_2.10
branch
from
131e705 to
4bf0a2f
Compare
k8s-ci-robot
removed
the
lgtm
|
Thanks for updating. /lgtm |
k8s-ci-robot
added
lgtm
* syntax issues * risky-file-permissions * var-naming * role-name * molecule tests
k8s-ci-robot
removed
lgtm
|
Had to rebase again after merging #7756 |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cristicalin, floryut The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Closed
7 tasks
| @@ -5,7 +5,7 @@ | |||
| changed_when: false | |||
|
|
|||
| - name: "Kubernetes Apps | Deploy cluster role binding." | |||
| when: "clusterrolebinding_state.stdout == \"\"" | |||
| when: "clusterrolebinding_state.stdout | length > 0" | |||
There was a problem hiding this comment.
This seems to be the opposite of the condition before the change.
There was a problem hiding this comment.
Wow man, thanks we missed that.
LuckySB
pushed a commit
to southbridgeio/kubespray
that referenced
this pull request
Oct 23, 2021
* Ansible: move to Ansible 3.4.0 which uses ansible-base 2.10.10 * Docs: add a note about ansible upgrade post 2.9.x * CI: ensure ansible is removed before ansible 3.x is installed to avoid pip failures * Ansible: use newer ansible-lint * Fix ansible-lint 5.0.11 found issues * syntax issues * risky-file-permissions * var-naming * role-name * molecule tests * Mitogen: use 0.3.0rc1 which adds support for ansible 2.10+ * Pin ansible-base to 2.10.11 to get package fix on RHEL8
sakuraiyuta
pushed a commit
to sakuraiyuta/kubespray
that referenced
this pull request
Apr 16, 2022
* Ansible: move to Ansible 3.4.0 which uses ansible-base 2.10.10 * Docs: add a note about ansible upgrade post 2.9.x * CI: ensure ansible is removed before ansible 3.x is installed to avoid pip failures * Ansible: use newer ansible-lint * Fix ansible-lint 5.0.11 found issues * syntax issues * risky-file-permissions * var-naming * role-name * molecule tests * Mitogen: use 0.3.0rc1 which adds support for ansible 2.10+ * Pin ansible-base to 2.10.11 to get package fix on RHEL8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
We should try to move and keep up with upstream ansible. Newer versions mandate the use of fully qualified module names and we would need our code to run with ansible 2.10 to start on this migration.
Which issue(s) this PR fixes:
Fixes #7671 #7689
Special notes for your reviewer:
Does this PR introduce a user-facing change?: