-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kubespray-defaults role #7841
Conversation
Welcome @SimonGurney! |
Hi @SimonGurney. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: SimonGurney The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@SimonGurney This pull request contains |
Fixes issues where an execution of remove-node.yml fails because a default value is not provided for proxy_disable_env
Apologies, I think thats sorted now. Had some issues with my commit verification but sorted it out now |
This was fixed by #7729 |
@champtar: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes issues where an execution of remove-node.yml fails because a default value is not provided for proxy_disable_env
What type of PR is this?
/kind bug
What this PR does / why we need it:
Fixes and issue where remove-node.yml execution fails
Which issue(s) this PR fixes:
Fixes #7801
Special notes for your reviewer:
Running the tests is beyond me so please can someone do this. I have tested execution by provisioning, scaling and removing an node and that works fine in my scenario.
Does this PR introduce a user-facing change?:
No