Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kubespray-defaults role #7841

Closed
wants to merge 1 commit into from

Conversation

SimonGurney
Copy link

Fixes issues where an execution of remove-node.yml fails because a default value is not provided for proxy_disable_env

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change

/kind bug

/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
Fixes and issue where remove-node.yml execution fails
Which issue(s) this PR fixes:
Fixes #7801

Special notes for your reviewer:

Running the tests is beyond me so please can someone do this. I have tested execution by provisioning, scaling and removing an node and that works fine in my scenario.

Does this PR introduce a user-facing change?:
No


@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 30, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @SimonGurney!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 30, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @SimonGurney. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: SimonGurney
To complete the pull request process, please assign mirwan after the PR has been reviewed.
You can assign the PR to them by writing /assign @mirwan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from EppO and oomichi July 30, 2021 08:51
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 30, 2021
@oomichi
Copy link
Contributor

oomichi commented Jul 30, 2021

@SimonGurney This pull request contains invalid-commit-message.
Please read https://github.com/kubernetes/community/blob/master/contributors/guide/pull-requests.md#commit-message-guidelines to know what is invalid on the commit message and fix it.

@SimonGurney SimonGurney changed the title Add kubespray-defaults role to fix #7801 Add kubespray-defaults role Jul 30, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Jul 30, 2021
Fixes issues where an execution of remove-node.yml fails because a default value is not provided for proxy_disable_env
@SimonGurney
Copy link
Author

@SimonGurney This pull request contains invalid-commit-message.
Please read https://github.com/kubernetes/community/blob/master/contributors/guide/pull-requests.md#commit-message-guidelines to know what is invalid on the commit message and fix it.

Apologies, I think thats sorted now. Had some issues with my commit verification but sorted it out now

@champtar
Copy link
Contributor

This was fixed by #7729
/close

@k8s-ci-robot
Copy link
Contributor

@champtar: Closed this PR.

In response to this:

This was fixed by #7729
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@SimonGurney SimonGurney deleted the patch-1 branch August 11, 2021 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove-node fails on "'proxy_disable_env' is undefined"
4 participants