-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
addons/cert_manager: retries until webhook pods has been created #7850
addons/cert_manager: retries until webhook pods has been created #7850
Conversation
Fix task 'Cert Manager | Wait for Webhook pods become ready' failed due to webhook pods don't exist yet by using `retries..until` trick like kubernetes-sigs#7842 This fix should be removed in the future if the kubernetes/kubernetes#83242 is resolved. Signed-off-by: rtsp <[email protected]>
Hi @rtsp. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest failed test not related to code changes |
@rtsp: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floryut, rtsp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…ernetes-sigs#7850) Fix task 'Cert Manager | Wait for Webhook pods become ready' failed due to webhook pods don't exist yet by using `retries..until` trick like kubernetes-sigs#7842 This fix should be removed in the future if the kubernetes/kubernetes#83242 is resolved. Signed-off-by: rtsp <[email protected]>
…ernetes-sigs#7850) Fix task 'Cert Manager | Wait for Webhook pods become ready' failed due to webhook pods don't exist yet by using `retries..until` trick like kubernetes-sigs#7842 This fix should be removed in the future if the kubernetes/kubernetes#83242 is resolved. Signed-off-by: rtsp <[email protected]>
What type of PR is this?
/kind bug
What this PR does / why we need it:
cert-manager webhook pods are deployed via the deployment that need a few second delay after applying the manifests until the pods are created.
This cause
Cert Manager | Wait for Webhook pods become ready
task to failed occasionally with "error: no matching resources found" if it's run too fast becausekubectl wait
cannot wait for non-exist resources (see kubernetes/kubectl#1516).kubespray/roles/kubernetes-apps/ingress_controller/cert_manager/tasks/main.yml
Lines 70 to 76 in b958d6e
This fix is using
retries..until
trick similar to #7842.Special notes for your reviewer:
This fix should be removed in the future if the kubernetes/kubectl#1516 is resolved.
Does this PR introduce a user-facing change?: