-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(containerd): auth support #7868
Conversation
Hi @faust64. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/cc @oomichi
Thanks for updating. /lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@faust64 thanks for that
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: faust64, floryut The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
The pull request which fixes packet_debian10-containerd has been merged as 7916649 |
Thanks for updating. /lgtm |
* feat(containerd): auth support * fix(registry-auth): rename variable
* feat(containerd): auth support * fix(registry-auth): rename variable
What type of PR is this?
What this PR does / why we need it:
Completing #7837 , which only addresses cri-o
Somewhat related to #1301 .
According to https://github.com/containerd/containerd/blob/main/docs/cri/registry.md#configure-registry-credentials
Which issue(s) this PR fixes:
None. Partially addresses #1301 (running containerd).
Special notes for your reviewer:
I've named my registry_auth variable matching that of #7837 . Though maybe we would want to keep prefixing those variables with CRI name (eg:
containerd_registry_auth
,crio_registry_auth
).Or, going without prefixes, maybe move the sample variable out of
all/<CRI>
and intok8s_cluster/k8s-cluster
.