-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean kubeadm-config cm from removed etcd nodes endPoints #8244
Clean kubeadm-config cm from removed etcd nodes endPoints #8244
Conversation
…-config configmap
Hi @Alvaro-Campesino. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Ubuntu20 file download failed in the Molecule_test. https://gitlab.com/kargo-ci/kubernetes-sigs-kubespray/-/jobs/1829080591#L2207 Doesn't seem relatedo the the PR contents. |
Hi, Could you please review the docker account and the status of the failed download and relaunch the tests? Best regards |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
/cc @oomichi @cristicalin @EppO
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Alvaro-Campesino, floryut The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thank you @Alvaro-Campesino for this fix! /lgtm |
Removing it from the release-note (and reverting it) while we address the errors raised in issues |
… kubeadm-config configmap (kubernetes-sigs#8244)" (kubernetes-sigs#8287) This reverts commit dc767c1.
… kubeadm-config configmap (kubernetes-sigs#8244)" (kubernetes-sigs#8287) This reverts commit dc767c1.
… kubeadm-config configmap (kubernetes-sigs#8244)" (kubernetes-sigs#8287) This reverts commit dc767c1.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This PR cleans the kubeadm-config configmap from information of etcd-nodes that are no longer present. This avoids issues when trying to rejoining this nodes
Which issue(s) this PR fixes:
Fixes #8235
Special notes for your reviewer:
Does this PR introduce a user-facing change?: