Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean kubeadm-config cm from removed etcd nodes endPoints #8244

Conversation

Alvaro-Campesino
Copy link
Contributor

@Alvaro-Campesino Alvaro-Campesino commented Nov 29, 2021

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
This PR cleans the kubeadm-config configmap from information of etcd-nodes that are no longer present. This avoids issues when trying to rejoining this nodes

Which issue(s) this PR fixes:

Fixes #8235

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Cleanup kubeadm-config cm by removing etcd nodes endPoints no longer valid

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 29, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @Alvaro-Campesino. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 29, 2021
@Alvaro-Campesino
Copy link
Contributor Author

Ubuntu20 file download failed in the Molecule_test.

https://gitlab.com/kargo-ci/kubernetes-sigs-kubespray/-/jobs/1829080591#L2207

Doesn't seem relatedo the the PR contents.

@Alvaro-Campesino
Copy link
Contributor Author

Hi,
CI/CD failed because the pulls limits for docker was reached, except for packet_fedora35 that was a not found error

Could you please review the docker account and the status of the failed download and relaunch the tests?

Best regards

Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/cc @oomichi @cristicalin @EppO

@k8s-ci-robot k8s-ci-robot requested a review from EppO December 1, 2021 09:26
@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 1, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Alvaro-Campesino, floryut

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 1, 2021
@cristicalin
Copy link
Contributor

Thank you @Alvaro-Campesino for this fix!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 1, 2021
@k8s-ci-robot k8s-ci-robot merged commit dc767c1 into kubernetes-sigs:master Dec 1, 2021
@floryut floryut added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 2, 2021
floryut added a commit that referenced this pull request Dec 9, 2021
@floryut floryut added the release-note-none Denotes a PR that doesn't merit a release note. label Dec 9, 2021
@floryut
Copy link
Member

floryut commented Dec 9, 2021

Removing it from the release-note (and reverting it) while we address the errors raised in issues

k8s-ci-robot pushed a commit that referenced this pull request Dec 9, 2021
nmasse-itix pushed a commit to nmasse-itix/kubespray that referenced this pull request Dec 20, 2021
sakuraiyuta pushed a commit to sakuraiyuta/kubespray that referenced this pull request Apr 16, 2022
sakuraiyuta pushed a commit to sakuraiyuta/kubespray that referenced this pull request Apr 16, 2022
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jun 28, 2023
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove from kubeadm-config configmap an etcd-node while removing it
4 participants