-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
containerd: change default resolvconf_mode to host_resolvconf #8247
Merged
k8s-ci-robot
merged 7 commits into
kubernetes-sigs:master
from
simplekube-ro:default_host_resolvconf
Dec 9, 2021
Merged
containerd: change default resolvconf_mode to host_resolvconf #8247
k8s-ci-robot
merged 7 commits into
kubernetes-sigs:master
from
simplekube-ro:default_host_resolvconf
Dec 9, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/bug
Categorizes issue or PR as related to a bug.
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
labels
Nov 29, 2021
floryut
added
kind/container-managers
Containers section in the release note
and removed
kind/bug
Categorizes issue or PR as related to a bug.
labels
Nov 29, 2021
floryut
approved these changes
Nov 29, 2021
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cristicalin, floryut The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
label
Nov 29, 2021
cristicalin
force-pushed
the
default_host_resolvconf
branch
from
November 29, 2021 11:16
d197a9c
to
c24c6cb
Compare
/hold |
k8s-ci-robot
added
do-not-merge/hold
Indicates that a PR should not merge because someone has issued a /hold command.
needs-rebase
Indicates a PR cannot be merged because it has merge conflicts with HEAD.
labels
Dec 2, 2021
cristicalin
force-pushed
the
default_host_resolvconf
branch
from
December 5, 2021 10:08
c24c6cb
to
aade47c
Compare
k8s-ci-robot
added
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
and removed
needs-rebase
Indicates a PR cannot be merged because it has merge conflicts with HEAD.
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
labels
Dec 5, 2021
cristicalin
force-pushed
the
default_host_resolvconf
branch
2 times, most recently
from
December 6, 2021 07:37
19b7e13
to
f5933a3
Compare
k8s-ci-robot
added
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
and removed
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
labels
Dec 6, 2021
cristicalin
force-pushed
the
default_host_resolvconf
branch
3 times, most recently
from
December 7, 2021 14:59
16ad6a8
to
edefdbc
Compare
cristicalin
force-pushed
the
default_host_resolvconf
branch
from
December 9, 2021 07:55
edefdbc
to
16f513c
Compare
k8s-ci-robot
removed
the
do-not-merge/hold
Indicates that a PR should not merge because someone has issued a /hold command.
label
Dec 9, 2021
Thanks for doing this. /lgtm |
k8s-ci-robot
added
the
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
label
Dec 9, 2021
nmasse-itix
pushed a commit
to nmasse-itix/kubespray
that referenced
this pull request
Dec 20, 2021
…etes-sigs#8247) * containerd: change default resolvconf_mode to host_resolvconf * Wait for kube-apiserver to come back after pod refresh * Handle resolv.conf gracefully * Retain currently configured DNS entries to ensure we don't break the resolvers * Suse uses wickedd for network management so no dhcp hooks * Molecule: increase ansible timeout * CI: Increase ansible timeout to 120s for Packet jobs
Closed
fungusakafungus
added a commit
to fungusakafungus/kubespray
that referenced
this pull request
Jan 31, 2022
k8s-ci-robot
pushed a commit
that referenced
this pull request
Jan 31, 2022
sakuraiyuta
pushed a commit
to sakuraiyuta/kubespray
that referenced
this pull request
Apr 16, 2022
…etes-sigs#8247) * containerd: change default resolvconf_mode to host_resolvconf * Wait for kube-apiserver to come back after pod refresh * Handle resolv.conf gracefully * Retain currently configured DNS entries to ensure we don't break the resolvers * Suse uses wickedd for network management so no dhcp hooks * Molecule: increase ansible timeout * CI: Increase ansible timeout to 120s for Packet jobs
sakuraiyuta
pushed a commit
to sakuraiyuta/kubespray
that referenced
this pull request
Apr 16, 2022
LuckySB
pushed a commit
to southbridgeio/kubespray
that referenced
this pull request
Jun 28, 2023
…etes-sigs#8247) * containerd: change default resolvconf_mode to host_resolvconf * Wait for kube-apiserver to come back after pod refresh * Handle resolv.conf gracefully * Retain currently configured DNS entries to ensure we don't break the resolvers * Suse uses wickedd for network management so no dhcp hooks * Molecule: increase ansible timeout * CI: Increase ansible timeout to 120s for Packet jobs
LuckySB
pushed a commit
to southbridgeio/kubespray
that referenced
this pull request
Jun 29, 2023
LuckySB
pushed a commit
to southbridgeio/kubespray
that referenced
this pull request
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
kind/container-managers
Containers section in the release note
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
With the transition to containerd as our default container_manager we need to ensure the DNS resolution is correctly configured by default out of the box.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: