Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nerdctl insecure registry config #8339

Merged
merged 13 commits into from
Jan 5, 2022
Merged

nerdctl insecure registry config #8339

merged 13 commits into from
Jan 5, 2022

Conversation

mircyb
Copy link
Contributor

@mircyb mircyb commented Dec 25, 2021 •
edited
Loading

nerdctl insecure registry config

nerdctl insecure config doesn't refer to containerd config (/etc/containerd/config.toml)

currently nerdctl can't use insecure registry

to download from insecure registry using nerdctl must be use --insecure-registy option

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
/kind feature
Which issue(s) this PR fixes:

Fixes #8336

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

[containerd] nerdctl insecure registry support

@mircyb
Update prep_download.yml
90faa90 
nerdctl insecure registry config
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 25, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @mircyb. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot requested review from EppO and oomichi December 25, 2021 21:57
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 25, 2021
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 25, 2021
@mircyb
Update prep_download.yml
9d64df5 
apply conversations advice
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 2, 2022
@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 5, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 5, 2022
floryut
floryut approved these changes Jan 5, 2022
View reviewed changes
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mircyb Neat 👍

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, mircyb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@floryut floryut added the kind/container-managers Containers section in the release note label Jan 5, 2022
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 5, 2022
@k8s-ci-robot k8s-ci-robot merged commit 24f1402 into kubernetes-sigs:master Jan 5, 2022
sathieu added a commit to sathieu/kubespray that referenced this pull request Jan 12, 2022
@sathieu
Allow to choose container manager commands (kubernetes-sigs#8380)
6cda67c 
This allow to workaround kubernetes-sigs#8375 by using image_command_tool=crictl
when containerd_registries is used for containerd.

Also changes image_info_command_on_localhost for docker to return digests.

(cherry picked from commit cfd9873)

The cherry-pick was adapted because nerdctl_extra_flags is not in
the release-2.18 branch (kubernetes-sigs#8339).
This was referenced Jan 12, 2022
Closed
Closed
Closed
Merged
k8s-ci-robot pushed a commit that referenced this pull request Jan 17, 2022
@sathieu @k8s-ci-robot
Allow to choose container manager commands (#8380)
7fffe67 
This allow to workaround #8375 by using image_command_tool=crictl
when containerd_registries is used for containerd.

Also changes image_info_command_on_localhost for docker to return digests.

(cherry picked from commit cfd9873)

The cherry-pick was adapted because nerdctl_extra_flags is not in
the release-2.18 branch (#8339).
tmurakam added a commit to kubespray-offline/kubespray-offline that referenced this pull request Feb 6, 2022
@tmurakam
fix: hack nerdctl --insecure-registry flag
771f99b 
see kubernetes-sigs/kubespray#8339
tmurakam added a commit to kubespray-offline/kubespray-offline that referenced this pull request Feb 6, 2022
@tmurakam
fix: hack nerdctl --insecure-registry flag
f7f6d41 
see kubernetes-sigs/kubespray#8339
ghost pushed a commit to kubespray-offline/kubespray-offline that referenced this pull request Feb 7, 2022
@tmurakam
fix: hack nerdctl --insecure-registry flag
ed99f0e 
see kubernetes-sigs/kubespray#8339
tmurakam pushed a commit to tmurakam/kubespray that referenced this pull request Mar 4, 2022
@mircyb @tmurakam
[PATCH] nerdctl insecure registry config (kubernetes-sigs#8339)
03f148e 
Backport kubernetes-sigs#8339 to 2.18-release
tmurakam pushed a commit to tmurakam/kubespray that referenced this pull request Mar 4, 2022
@mircyb @tmurakam
[PATCH] nerdctl insecure registry config (kubernetes-sigs#8339)
13040ab 
Backport kubernetes-sigs#8339 to 2.18-release
Cherry-pick 24f1402
tmurakam pushed a commit to tmurakam/kubespray that referenced this pull request Mar 4, 2022
@mircyb @tmurakam
[PATCH] nerdctl insecure registry config (kubernetes-sigs#8339)
1933874 
Backport kubernetes-sigs#8339 to 2.18-release
Cherry-pick 24f1402
@tmurakam tmurakam mentioned this pull request Mar 4, 2022
Merged
tmurakam pushed a commit to tmurakam/kubespray that referenced this pull request Mar 6, 2022
@mircyb @tmurakam
[PATCH] nerdctl insecure registry config (kubernetes-sigs#8339)
3027d03 
Backport kubernetes-sigs#8339 to 2.18-release
Cherry-pick 24f1402
k8s-ci-robot pushed a commit that referenced this pull request Mar 8, 2022
@tmurakam @mircyb
[PATCH] nerdctl insecure registry config (#8339) (#8601)
0c43883 
Backport #8339 to 2.18-release
Cherry-pick 24f1402

Co-authored-by: Choi Yongbeom <[email protected]>
sakuraiyuta pushed a commit to sakuraiyuta/kubespray that referenced this pull request Apr 16, 2022
@mircyb @sakuraiyuta
nerdctl insecure registry config (kubernetes-sigs#8339)
cc46189 
* Update prep_download.yml

nerdctl insecure registry config

* Update prep_download.yml

* Update prep_download.yml

apply conversations advice

* Update prep_download.yml

* Update prep_download.yml

* Update prep_download.yml

* Update prep_download.yml

* Update prep_download.yml

* Update prep_download.yml

* Update main.yml

* Update main.yml

* Update prep_download.yml

* Update prep_download.yml
@oomichi oomichi mentioned this pull request May 28, 2022
Closed
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jun 29, 2023
@mircyb @LuckySB
nerdctl insecure registry config (kubernetes-sigs#8339)
8b0b189 
* Update prep_download.yml

nerdctl insecure registry config

* Update prep_download.yml

* Update prep_download.yml

apply conversations advice

* Update prep_download.yml

* Update prep_download.yml

* Update prep_download.yml

* Update prep_download.yml

* Update prep_download.yml

* Update prep_download.yml

* Update main.yml

* Update main.yml

* Update prep_download.yml

* Update prep_download.yml
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Oct 20, 2023
@mircyb @LuckySB
nerdctl insecure registry config (kubernetes-sigs#8339)
af14399 
* Update prep_download.yml

nerdctl insecure registry config

* Update prep_download.yml

* Update prep_download.yml

apply conversations advice

* Update prep_download.yml

* Update prep_download.yml

* Update prep_download.yml

* Update prep_download.yml

* Update prep_download.yml

* Update prep_download.yml

* Update main.yml

* Update main.yml

* Update prep_download.yml

* Update prep_download.yml
@tmurakam tmurakam mentioned this pull request Jan 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristicalin cristicalin cristicalin left review comments

@floryut floryut floryut approved these changes

@EppO EppO Awaiting requested review from EppO

@oomichi oomichi Awaiting requested review from oomichi

Assignees

@cristicalin cristicalin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/container-managers Containers section in the release note lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nerdctl can't use insecure registry
4 participants
@mircyb @k8s-ci-robot @cristicalin @floryut