-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve first_kube_control_plane variable management to avoid install… #8388
Improve first_kube_control_plane variable management to avoid install… #8388
Conversation
…ation failures due to variable overlapping
Hi @unai-ttxu. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@unai-ttxu thanks for catching this!
/ok-to-test
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@unai-ttxu Good one 🙇
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cristicalin, floryut, unai-ttxu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…ation failures due to variable overlapping (kubernetes-sigs#8388)
…ation failures due to variable overlapping (kubernetes-sigs#8388)
…ation failures due to variable overlapping (kubernetes-sigs#8388)
…ation failures due to variable overlapping (kubernetes-sigs#8388)
…ation failures due to variable overlapping
What type of PR is this?
/kind bug
What this PR does / why we need it:
To fix the issue referred below.
Which issue(s) this PR fixes:
Fixes #8387
Special notes for your reviewer:
If you hace any doubt about the PR or the issue feel free to discuss it 😄
Does this PR introduce a user-facing change?: