Add unit test for print_hostnames of inventory.py #8558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
kind/cleanup
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
size/XS
oomichi
force-pushed
the
add-print_hostnames_test
branch
2 times, most recently
from
fe0e790 to
4fd6b86
Compare
|
Unknown CLA label state. Rechecking for CLA labels. Send feedback to sig-contributor-experience at kubernetes/community. /check-cla |
k8s-ci-robot
added
the
cncf-cla: yes
floryut
approved these changes
Feb 18, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floryut, oomichi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
Sorry, the unit test was not a good implementation. |
This adds a unit test for the function.
oomichi
force-pushed
the
add-print_hostnames_test
branch
from
4fd6b86 to
468c57b
Compare
k8s-ci-robot
added
size/S
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
@oomichi 👍 /lgtm |
k8s-ci-robot
added
the
lgtm
sakuraiyuta
pushed a commit
to sakuraiyuta/kubespray
that referenced
this pull request
Apr 16, 2022
This adds a unit test for the function.
LuckySB
pushed a commit
to southbridgeio/kubespray
that referenced
this pull request
Jun 29, 2023
This adds a unit test for the function.
LuckySB
pushed a commit
to southbridgeio/kubespray
that referenced
this pull request
Oct 23, 2023
This adds a unit test for the function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This adds a unit test for the function.
I missed to add the corresponding unit test on #8554
Does this PR introduce a user-facing change?: