-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(calico): add configurable ipam strictaffinity #8581
feat(calico): add configurable ipam strictaffinity #8581
Conversation
|
Welcome @eyenx! |
Hi @eyenx. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
c203ffd
to
0e48525
Compare
|
||
- name: Calico | Configure ipam strictaffinity to true | ||
command: | ||
cmd: "{{ bin_dir }}/calicoctl.sh ipam configure --strictaffinity=true" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what I can tell this approach will only enable strict affinity, if a deployer later decides to disable strict affinity this will not help. If so, why does this need to be part of the deployment process if it can be easily enabled via calicoctl later on? Ideally the deployment tool should configure parameters that end up in configuration files that are later more difficult to change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are totally right @cristicalin I'm changing this so that it will enable
or disable
(defualt) the strictaffinity accordingly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eyenx please squash the commits into a single one to keep the history clean, then we can merge this change. |
a26d80d
to
7b4c135
Compare
Signed-off-by: Toni Tauro <[email protected]>
7b4c135
to
da5671b
Compare
@cristicalin done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eyenx Thank you
/ok-to-test
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eyenx, floryut The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
) Signed-off-by: Toni Tauro <[email protected]>
) Signed-off-by: Toni Tauro <[email protected]>
) Signed-off-by: Toni Tauro <[email protected]>
What type of PR is this?
/kind feature
What this PR does / why we need it:
User can now configure IPAM Strictaffinity in case they need it to be enabled. This is needed a.e. for Windows Nodes integration
Which issue(s) this PR fixes:
Fixes #8583
Special notes for your reviewer:
Does this PR introduce a user-facing change?: