-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add IPv6 listen directive to nginx if enable_dual_stack_networks #8596
add IPv6 listen directive to nginx if enable_dual_stack_networks #8596
Conversation
Hi @kakkotetsu. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Thanks for this @kakkotetsu ! /ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floryut, kakkotetsu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
In a dual stack cluster with
kubelet --node-ip <IPv6 addr>,<IPv4 addr>
, IPv6 is preferred. In that case, theIP
of thenginx-proxy
pod will also be IPv6, so IPv6 listen directive is required. This PR add it.(This is not required, since kubespray is set to
kubelet --node-ip <IPv4 addr>,<IPv6addr>
at the moment.)Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: