Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add fix for GCP CSI driver #8616

Merged
merged 1 commit into from
May 3, 2022
Merged

add fix for GCP CSI driver #8616

merged 1 commit into from
May 3, 2022

Conversation

lmercl
Copy link
Contributor

@lmercl lmercl commented Mar 8, 2022 •
edited by floryut
Loading

Signed-off-by: Lubos Mercl [email protected]

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
FIX GCP PVC creation on k8s v1.22

Which issue(s) this PR fixes:

Fixes #8579

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Fix GCP PVC creation on k8s v1.22

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 8, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @lmercl. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 8, 2022
@k8s-ci-robot k8s-ci-robot requested review from alijahnas and bozzo March 8, 2022 13:44
@cristicalin
Copy link
Contributor

Thanks for fixing this @lmercl.

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 9, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 9, 2022
@cristicalin
Copy link
Contributor

@lmercl please address the linting issues

floryut
floryut approved these changes Mar 11, 2022
View reviewed changes
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lmercl As stated by @cristicalin, please check linting otherwise 👍

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, lmercl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Mar 11, 2022
oomichi
oomichi reviewed Mar 15, 2022
View reviewed changes
Copy link
Contributor

@oomichi oomichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @oomichi

roles/kubernetes-apps/csi_driver/gcp_pd/defaults/main.yml Outdated
gcp_pd_csi_driver_image_tag: "v0.7.0-gke.0"
# gcp_pd_csi_driver_image_tag: "v1.4.0"

# csi_attacher_image_repo: "{{ kube_image_repo }}/sig-storage/csi-attacher"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't you enable these lines?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @oomichi ,
sorry for late reply. This is commented, because they are defined in roles/download/defaults/main.yml by default and not needed rewrite in this area but I kept them for possible rewrite. Of course, this can be deleted because it's copied from mensioned file.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your explanation, @lmercl
It is better to delete those lines.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oomichi Hello, ok I deleted them.

@k8s-ci-robot k8s-ci-robot requested a review from oomichi March 15, 2022 20:44
@cristicalin
Copy link
Contributor

@lmercl could you address the questions from @oomichi so we can proceed with this work?

@cristicalin
Copy link
Contributor

@lmercl this PR needs a rebase to work with the updated ansible base

@lmercl
Copy link
Contributor Author

lmercl commented Apr 6, 2022

/retest

@cristicalin
Copy link
Contributor

@lmercl this PR needs a rebase on latest state of the master branch to pick up some CI fixes

@lmercl
add fix for GCP CSI driver
fd80272 
Signed-off-by: Lubos Mercl <[email protected]>
@oomichi
Copy link
Contributor

oomichi commented May 3, 2022

Thanks for updating and rebasing.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 3, 2022
@k8s-ci-robot k8s-ci-robot merged commit c20ab7d into kubernetes-sigs:master May 3, 2022
@oomichi oomichi mentioned this pull request May 28, 2022
Closed
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jun 30, 2023
@lmercl @LuckySB
add fix for GCP CSI driver (kubernetes-sigs#8616)
275cb89 
Signed-off-by: Lubos Mercl <[email protected]>
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Oct 23, 2023
@lmercl @LuckySB
add fix for GCP CSI driver (kubernetes-sigs#8616)
65f66b0 
Signed-off-by: Lubos Mercl <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floryut floryut floryut approved these changes

@alijahnas alijahnas Awaiting requested review from alijahnas

@bozzo bozzo Awaiting requested review from bozzo

@oomichi oomichi Awaiting requested review from oomichi

Assignees

@oomichi oomichi

@cristicalin cristicalin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kubespray GCE PVC provisioning is not working on k8s 1.22 in release 2.18
5 participants
@lmercl @k8s-ci-robot @cristicalin @oomichi @floryut