Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: uninstall contailer engine if service is running #8662

Merged
merged 1 commit into from
Apr 1, 2022
Merged

fix: uninstall contailer engine if service is running #8662

merged 1 commit into from
Apr 1, 2022

Conversation

cyril-corbon
Copy link
Contributor

@cyril-corbon cyril-corbon commented Mar 29, 2022 •
edited
Loading

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

/kind bug

What this PR does / why we need it:
Uninstall a container engine only if service is running and systemd files are present

Which issue(s) this PR fixes:

Fixes #8609

Special notes for your reviewer:
I found several issues with the role validate-container-engine
I will fix them in multiple pr and follow them on this one: #8609

Does this PR introduce a user-facing change?:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 29, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @cyril-corbon. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 29, 2022
@k8s-ci-robot k8s-ci-robot requested review from EppO and oomichi March 29, 2022 20:26
@cristicalin
Copy link
Contributor

Thanks for this @cyril-corbon !

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 31, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 31, 2022
@oomichi
Copy link
Contributor

oomichi commented Apr 1, 2022

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cyril-corbon, oomichi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cyril-corbon, oomichi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 1, 2022
@k8s-ci-robot k8s-ci-robot merged commit 1781eab into kubernetes-sigs:master Apr 1, 2022
This was referenced Apr 3, 2022
Closed
Merged
Quehenr pushed a commit to Quehenr/unstable-laboratory-infrastructure-kubespray that referenced this pull request Apr 4, 2022
Merge branch 'master' into feature/virtualbox
ba85ed8 
* master: (21 commits)
  Fix quotation of nerdctl_extra_flags (kubernetes-sigs#8668)
  fix: uninstall contailer engine if service is running (kubernetes-sigs#8662)
  fix disk controller type in Vagrantfile (kubernetes-sigs#8656)
  Add ETCD_EXPERIMENTAL_INITIAL_CORRUPT_CHECK flag to etcd config (kubernetes-sigs#8664)
  Update vagrant.md (kubernetes-sigs#8663)
  Add missing 2.10 ansible test (kubernetes-sigs#8665)
  [ansible] make ansible 5.x the new default version (kubernetes-sigs#8660)
  Run 0100-dhclient-hooks if dhcpclient is enabled (kubernetes-sigs#8658)
  terrform/openstack: Fix templating of ansible_ssh_common_args in no_floating.yml if used as TF module (kubernetes-sigs#8646)
  [ansible] add support for ansible 5 (ansible-core 2.12) (kubernetes-sigs#8512)
  [etcd] add 0 hash for arm v3.5.2 to prevent deployment failures
  Update cert-manager to v1.7.2 (kubernetes-sigs#8648)
  fix vagrant parameter (kubernetes-sigs#8650)
  Remove centos7 molecule while opensuse mirror is flaky
  Remove k8s module for ns creation
  Update kubernetes image to 2.18.1
  Vagrantfile: add var to set ansible verbosity level (kubernetes-sigs#8639)
  Have ingress_controller and external_provisioner in upgrade-cluster.yml (kubernetes-sigs#8640)
  [sysctl] set fs.may_detach_mounts=1 even when CRIs don't set it themselves (kubernetes-sigs#8635)
  Fixed cluster roles for openstack cloud controller (kubernetes-sigs#8638)
  ...
sakuraiyuta pushed a commit to sakuraiyuta/kubespray that referenced this pull request Apr 16, 2022
@cyril-corbon @sakuraiyuta
fix: uninstall contailer engine if service is running (kubernetes-sig…
085cd00 
…s#8662)
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jun 29, 2023
@cyril-corbon @LuckySB
fix: uninstall contailer engine if service is running (kubernetes-sig…
0caf980 
…s#8662)
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Oct 23, 2023
@cyril-corbon @LuckySB
fix: uninstall contailer engine if service is running (kubernetes-sig…
166663e 
…s#8662)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EppO EppO Awaiting requested review from EppO

@oomichi oomichi Awaiting requested review from oomichi

Assignees

@oomichi oomichi

@cristicalin cristicalin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Single node upgrades are broken by container_manager replacement logic
4 participants
@cyril-corbon @k8s-ci-robot @cristicalin @oomichi