[2.18] cert-manager: leader election namespace fixes #8681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fixes from master cherry-picked from * ccd3180 cert-manager: Fix incorrect leader election namespace lead to insufficient permission (kubernetes-sigs#8433) * e791089 cert-manager: Allow to change leader election namespace for GKE Autopilot support (kubernetes-sigs#8424)
k8s-ci-robot
added
kind/bug
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
Thanks @rtsp ! /approve |
cristicalin
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: cristicalin, rtsp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
This is a backport of cert-manager leader election namespace fixes to
kubespray-2.18which I backported from these commitsWhich issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
cert-manager is unusable in 2.18 branch due to this bug.
Does this PR introduce a user-facing change?: