Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

etcd: add etcd v3.5.3 for kubernetes 1.21+ #8712

Merged
merged 1 commit into from
Apr 14, 2022
Merged

etcd: add etcd v3.5.3 for kubernetes 1.21+ #8712

merged 1 commit into from
Apr 14, 2022

Conversation

mzaian
Copy link
Contributor

@mzaian mzaian commented Apr 13, 2022

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind feature

What this PR does / why we need it:
As per this issue #8664 I propose to make etcd v.3.5.3 default for any kubernetes version which uses 3.5.x since that 3.5.[0-2] not recommended for production.

I would also recommend to create a new release for this.

References:
etcd-io/etcd#13766
https://groups.google.com/g/etcd-dev/c/sad9tgmKU7Y/m/vhArFVevBgAJ
etcd-io/etcd#13894

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

[etcd] add v3.5.3 for kubernetes 1.21+

@mzaian
etcd: add etcd v3.5.3 for kubernetes 1.21+
36a520a 
* As per this issue #8664 I propose to make etcd v.3.5.3 default for any kubernetes version which uses 3.5.x since that 3.5.[0-2] not recommended for production.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 13, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @mzaian. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 13, 2022
@k8s-ci-robot k8s-ci-robot requested review from EppO and oomichi April 13, 2022 21:20
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 13, 2022
@oomichi
Copy link
Contributor

oomichi commented Apr 14, 2022

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 14, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 14, 2022
@cristicalin
Copy link
Contributor

@mzaian 👍

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cristicalin, mzaian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 14, 2022
@k8s-ci-robot k8s-ci-robot merged commit 7e7218f into kubernetes-sigs:master Apr 14, 2022
Quehenr pushed a commit to Quehenr/unstable-laboratory-infrastructure-kubespray that referenced this pull request Apr 16, 2022
Merge branch 'master' into feature/virtualbox
2b5365e 
* master:
  metallb: Add images to downloads (kubernetes-sigs#8715)
  etcd: add etcd v3.5.3 for kubernetes 1.21+ (kubernetes-sigs#8712)
  [calico] call calico checks early on to prevent altering the cluster with bad configuration (kubernetes-sigs#8707)
sakuraiyuta pushed a commit to sakuraiyuta/kubespray that referenced this pull request Apr 16, 2022
@mzaian @sakuraiyuta
etcd: add etcd v3.5.3 for kubernetes 1.21+ (kubernetes-sigs#8712)
4e8129b 
* As per this issue kubernetes-sigs#8664 I propose to make etcd v.3.5.3 default for any kubernetes version which uses 3.5.x since that 3.5.[0-2] not recommended for production.
@floryut floryut added the release-note-none Denotes a PR that doesn't merit a release note. label Apr 25, 2022
notCalle pushed a commit to notCalle/kubespray that referenced this pull request Jun 8, 2022
@mzaian @notCalle
etcd: add etcd v3.5.3 for kubernetes 1.21+ (kubernetes-sigs#8712)
90c145b 
* As per this issue kubernetes-sigs#8664 I propose to make etcd v.3.5.3 default for any kubernetes version which uses 3.5.x since that 3.5.[0-2] not recommended for production.
@mzaian mzaian mentioned this pull request Jun 9, 2022
Closed
9 tasks
unai-ttxu pushed a commit to Stratio/kubespray that referenced this pull request Jun 21, 2022
@mzaian @unai-ttxu
etcd: add etcd v3.5.3 for kubernetes 1.21+ (kubernetes-sigs#8712)
0d2fbc8 
* As per this issue kubernetes-sigs#8664 I propose to make etcd v.3.5.3 default for any kubernetes version which uses 3.5.x since that 3.5.[0-2] not recommended for production.
notCalle pushed a commit to notCalle/kubespray that referenced this pull request Sep 7, 2022
@mzaian @notCalle
etcd: add etcd v3.5.3 for kubernetes 1.21+ (kubernetes-sigs#8712)
8a56ee3 
* As per this issue kubernetes-sigs#8664 I propose to make etcd v.3.5.3 default for any kubernetes version which uses 3.5.x since that 3.5.[0-2] not recommended for production.
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jun 30, 2023
@mzaian @LuckySB
etcd: add etcd v3.5.3 for kubernetes 1.21+ (kubernetes-sigs#8712)
423d6df 
* As per this issue kubernetes-sigs#8664 I propose to make etcd v.3.5.3 default for any kubernetes version which uses 3.5.x since that 3.5.[0-2] not recommended for production.
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Oct 23, 2023
@mzaian @LuckySB
etcd: add etcd v3.5.3 for kubernetes 1.21+ (kubernetes-sigs#8712)
fe4f30c 
* As per this issue kubernetes-sigs#8664 I propose to make etcd v.3.5.3 default for any kubernetes version which uses 3.5.x since that 3.5.[0-2] not recommended for production.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EppO EppO Awaiting requested review from EppO

@oomichi oomichi Awaiting requested review from oomichi

Assignees

@oomichi oomichi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mzaian @k8s-ci-robot @oomichi @cristicalin @floryut