Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop containerd 1.4 support #8780

Merged
merged 1 commit into from
May 5, 2022

Conversation

oomichi
Copy link
Contributor

@oomichi oomichi commented May 3, 2022

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

The version 1.4 of containerd has been End of Life since March 3, 2022 as https://containerd.io/releases/#support-horizon
It is nice to drop the support from Kubespray also to follow containerd.

Does this PR introduce a user-facing change?:

Drop containerd 1.4 support

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 3, 2022
@k8s-ci-robot k8s-ci-robot requested review from cristicalin and EppO May 3, 2022 16:37
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oomichi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 3, 2022
@cristicalin
Copy link
Contributor

cristicalin commented May 3, 2022

The ubuntu 18 failure in the cri-o molecule job seems rather odd. Similar failure shows up in #8779

@cristicalin
Copy link
Contributor

@oomichi please rebase on master once #8782 is merged

@oomichi oomichi force-pushed the drop-old-containerd branch from daee4b9 to a9847a1 Compare May 4, 2022 12:53
@cristicalin
Copy link
Contributor

/lgtm

This makes sense as a cleanup before 2.19 is tagged.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 4, 2022

Verified

This commit was signed with the committer’s verified signature.
oliviertassinari Olivier Tassinari
The version 1.4 of containerd has been End of Life since March 3, 2022
as https://containerd.io/releases/#support-horizon
It is nice to drop the support from Kubespray also to follow containerd.
@oomichi oomichi force-pushed the drop-old-containerd branch from a9847a1 to 4ddade7 Compare May 5, 2022 01:18
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 5, 2022
@cristicalin cristicalin added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label May 5, 2022
@cristicalin
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 5, 2022
@k8s-ci-robot k8s-ci-robot merged commit fbcf426 into kubernetes-sigs:master May 5, 2022
@oomichi oomichi mentioned this pull request May 28, 2022
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jun 30, 2023
The version 1.4 of containerd has been End of Life since March 3, 2022
as https://containerd.io/releases/#support-horizon
It is nice to drop the support from Kubespray also to follow containerd.
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Oct 23, 2023
The version 1.4 of containerd has been End of Life since March 3, 2022
as https://containerd.io/releases/#support-horizon
It is nice to drop the support from Kubespray also to follow containerd.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants